1985156 - Investigate whether tab favicon principals are dead code

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, task)

Description

[Duncan McIntosh [:dmcintosh]]

Tabs can have a iconloadingprincipal attribute, which filters down into the icon image's triggeringprincipal attribute. However, it's not clear that iconloadingprincipal is ever set—it looks like since bug 1453751 that data URIs are always used, so there isn't much point in keeping it.

If https://searchfox.org/firefox-main/search?q=gBrowser.setIcon is comprehensive, only SessionStore can ever set it to non-null. If that's true, SessionStore should itself never set it to non-null unless the user has a profile that hasn't opened since bug 1472476, so there's no point keeping it at all. Alternatively, there is some reason, in which case it should probably be documented somewhere.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1985156 - Remove icon loading principal code. r=dao,mossop

This seems to come from bug 1472476. I think seven years later we can
probably stop restoring non-local favicons and simplify the code a bit.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6a0e2c7fe6e3
https://hg.mozilla.org/integration/autoland/rev/b1e18465bf75
Remove icon loading principal code. r=dao,sessionstore-reviewers,tabbrowser-reviewers,sthompson

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/b1e18465bf75