1985191 - WGSL: `atan2(2.0, 0.0)` results in a validation error

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect, P2)

Description

[Erich Gubler [:ErichDonGubler] (he/him)]

Steps to reproduce

1. Obtain a GPUDevice and call its createShaderModule method, like the following:

   const code = `
   fn do_thing() -> f32 {
     return atan2(0.0, -1.0);
   }`
   
   const adapter = await navigator.gpu.requestAdapter()
   const device = await adapter.requestDevice()
   device.createShaderModule({ code })
   

   Observe that the following error is returned in the web console:

   23:56:43.053 Uncaptured WebGPU error: Shader module creation failed: Shader validation error
   23:56:43.053
   Encountered one or more errors while creating shader module
   23:56:43.053
   WebGPU compilation info for shader module (1 error(s), 0 warning(s), 0 info)
   23:56:43.053
   
   Shader validation error: Function [0] 'do_thing' is invalid
     ┌─ :2:1
     │  
   2 │ ╭ fn do_thing() -> f32 {
   3 │ │   return atan2(0.0, -1.0);
     │ │                ^^^ naga::ir::Expression [0]
     │ ╰──────────────────────────^ naga::ir::Function [0]
     │  
     = Expression [0] is invalid
     = Abstract types may only appear in constant expressions
   

   I expect that this snippet run without any errors.

Comment 1

[Andy Leiserson [:aleiserson]]

Needs https://github.com/gfx-rs/wgpu/commit/084431b548eb204a20c6008e6f4d8acfa789357c (Sep. 24)

Comment 2

[Erich Gubler [:ErichDonGubler] (he/him)]

Confirmed fixed just now in my Firefox Nightly web console. 😀