1985336 - Sniff Matroska content to set correct mime type

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P1)

Description

[Alastor Wu [:alwu]]

We need to let nsMediaSniffer know how to detect Matroska content.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1985336 - part1 : support Matroska on MediaSniffer.

We can use nestegg to sniff the doc type and determine
whether the content is Matroska. However, at this stage we
cannot distinguish between audio and video; that will be handled
during demuxing. For now, we always return a video MIME type.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1985336 - part2 : add a Glean probe `mkv_content_count` to measure MKV usage.

Since MKV cannot yet be demuxed, we are unable to record codec usage in the codec_used [1] probe.
That probe will only reflect MKV usage once the MKV demuxer is implemented.

For now, we introduce a temporary probe to collect MKV usage data. This probe can be removed once codec_used includes MKV.

[1] https://searchfox.org/firefox-main/rev/856a307913c2b73765b4e88d32cf15ed05549cae/dom/media/metrics.yaml#690-706

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1985336 - part3 : disable `bug1377278.webm`.

This file contains a Matroska doc type but uses a .webm extension.
Before adding Matroska sniffing, the correct MIME type could not be
determined by nsMediaSniffer, so it defaulted to the extension (.webm).

After the change, it will be detected as Matroska, which results in
playback failure since Matroska is not yet supported.

As this file is essentially Matroska, it should be re-enabled in bug
1985419 once Matroska support is implemented.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/acf034a1986a
https://hg.mozilla.org/integration/autoland/rev/11206e208e98
part1 : support Matroska on MediaSniffer. r=media-playback-reviewers,kinetik
https://github.com/mozilla-firefox/firefox/commit/fd8726a03b0d
https://hg.mozilla.org/integration/autoland/rev/1d0261f4a05b
part2 : add a Glean probe `mkv_content_count` to measure MKV usage. r=media-playback-reviewers,kinetik
https://github.com/mozilla-firefox/firefox/commit/3803fbb9a62d
https://hg.mozilla.org/integration/autoland/rev/6acb30589886
part3 : disable `bug1377278.webm`. r=media-playback-reviewers,padenot

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1d12198024e9
https://hg.mozilla.org/integration/autoland/rev/f16328906b1d
Revert "Bug 1985336 - part3 : disable `bug1377278.webm`. r=media-playback-reviewers,padenot" for causing xpc failures @ test_mediasniffer_ext.js

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing xpc failures @ test_mediasniffer_ext.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/f16328906b1d53e5c0fd8964c1407f2d3195dd7f

[Push with failures]https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=Yc5_z6jCRjeI5deJ29n-SA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&searchStr=linux%2C24.04%2Copt%2Cxpcshell%2Ctests%2Ctest-linux2404-64%2Fopt-xpcshell%2Cx1&revision=6acb3058988668ba5baeb445fd4f8a24abba5574)

Failure log -> TEST-UNEXPECTED-FAIL | toolkit/components/mediasniffer/test/unit/test_mediasniffer_ext.js | onStartRequest - [onStartRequest : 58] "video/x-matroska" == "application/octet-stream"

Comment 7

[Alastor Wu [:alwu]]

Attachment: Bug 1985336 - part4 : update test result for mkv.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5c73472fa131
https://hg.mozilla.org/integration/autoland/rev/cbcbb5f9882a
part1 : support Matroska on MediaSniffer. r=media-playback-reviewers,kinetik
https://github.com/mozilla-firefox/firefox/commit/2d6e86881f34
https://hg.mozilla.org/integration/autoland/rev/42905a4d0e8e
part2 : add a Glean probe `mkv_content_count` to measure MKV usage. r=media-playback-reviewers,kinetik
https://github.com/mozilla-firefox/firefox/commit/620e3052f6ef
https://hg.mozilla.org/integration/autoland/rev/d02721406326
part3 : disable `bug1377278.webm`. r=media-playback-reviewers,padenot
https://github.com/mozilla-firefox/firefox/commit/d5f2a61a1fe1
https://hg.mozilla.org/integration/autoland/rev/76f85624496f
part4 : update test result for mkv. r=media-playback-reviewers,karlt

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cbcbb5f9882a
https://hg.mozilla.org/mozilla-central/rev/42905a4d0e8e
https://hg.mozilla.org/mozilla-central/rev/d02721406326
https://hg.mozilla.org/mozilla-central/rev/76f85624496f