198546 - Format -> Font submenu doesn't deal with "unknown" font

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect)

Description

[jag (Peter Annema)]

If the selection has a font applied that we don't know about (isn't one of the
three we assume or isn't one of the system fonts) we end up selecting "variable
width" instead of selecting nothing.

Comment 1

[Kathleen :Brade]

-->jag

jag--you should use cmd_fontFace and query it for the font (if this is what this
bug is about)

Comment 2

[Rafael Ebron (:rebron)]

Composer triage: nsbeta1+/adt2

Comment 3

[jag (Peter Annema)]

Attachment: Rewrite font submenu font selection code to be faster and to deal better with unknown fonts

Comment 4

[Kathleen :Brade]

Comment on attachment 120198 [details] [diff] [review]
Rewrite font submenu font selection code to be faster and to deal better with unknown fonts

you can use command api like this:
  var cmdParams = newCommandParams();
  goDoCommandParams( "cmd_fontFace",cmdParams);
  fontFaceStr = params.getCStringValue("actualFont")
  fontMenuState = params.getCStringValue("state_attribute");
  ...

Comment 5

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 120198 [details] [diff] [review]
Rewrite font submenu font selection code to be faster and to deal better with unknown fonts

r=glazman

Comment 6

[jag (Peter Annema)]

See bug 201650.

Comment 7

[jag (Peter Annema)]

Attachment: nsHTMLCSSUtils.cpp: Fixes a problem with not being able to select TT (fixed width font) anymore.

Comment 8

[jag (Peter Annema)]

Attachment: And make sure we still correctly claim no font face applies.

Comment 9

[jag (Peter Annema)]

Attachment: Speed up font selection code, when encountering unknown font, don't select anything

Comment 10

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 120684 [details] [diff] [review]
And make sure we still correctly claim no font face applies.

r=glazman

Comment 11

[jag (Peter Annema)]

Attachment: C++ and JS patch in one.

Since the previous JS patch somehow confuses the Mac menu code, falling back to
the old code, but doing a quick check to see if the default font applies. If
not, assume it's mixed or unknow and select nothing.

Comment 12

[jag (Peter Annema)]

Attachment: Oops, don't need that function any longer

Comment 13

[jag (Peter Annema)]

Attachment: Optimization pointed out by Neil

Since for some unknown reason the JS in attachment 120686 [details] [diff] [review] screws up on Mac,
I've gone back to the old (and less efficient) JS, but with a fix for this bug
(namely not selecting anything instead of "variable width" for unknown fonts.

Comment 14

[jag (Peter Annema)]

Comment on attachment 120704 [details] [diff] [review]
Optimization pointed out by Neil

Neil said r=Neil

Comment 15

[jag (Peter Annema)]

Checked in. Filed bug 202385 to deal with making this code use cmd_fontFace.

Comment 16

[(not reading, please use [e-mail] instead)]

do we need to make a similar fix in the compose window, where shuehan recently
added a font picker?

Comment 17

[Chris Petersen]

What's the best way of verifying this bug ?

Comment 18

[Chris Petersen]

Verified using the 2003-05-09-08 Macho build.