1985514 - [composable toolbar] Bottom toolbar not seen when starting search on home from cold start

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect)

Description

[Petru-Mugurel Lingurar [:petru]]

Attachment: BottomToolbarNotAnchoredToKeyboard.mp4

Steps to reproduce

1. Have the toolbar position set to the bottom of the screen
2. Have no tabs open to ensure cold start shows the home screen
3. Cold start the application
4. Tap on the toolbar to start search

Expected behaviour

The software keyboard appears and the toolbar is on top of it (y axis)

Actual behaviour

The software keyboard appears but the toolbar is underneath it (z axis)

Any additional information?

Only happens with cold starts, doing anything else, starting search from home after coming from other screens doesn't exhibit the issue.
Used git bisect to find that this is a regression after updating to the new Jetpack Compose version.
Does not happen after cold starts on browser and starting a search here for search terms, happens only on searches started from home.
Does not happen with the old toolbar.
Does not happen on Android 8 so different behaviour depending on Android versions show that whatever was changed is definitely buggy.

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1983174

:RyanVM, since you are the author of the regressor, bug 1983174, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Added a few more bits of information.
Given the very specific scenario in which this happens and other similar scenarios in which it doesn't I think we can find a workaround.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1985514 - Restore having the home bottom toolbar on top of keyboard after cold starts r=#android-reviewers

Investigations showed that insets listeners were not called in this scenario but
using a View instead of the newly built ComposeView restores the behavior we had.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/14c17b6ec1e8
https://hg.mozilla.org/integration/autoland/rev/b3167225bd7e
Restore having the home bottom toolbar on top of keyboard after cold starts r=android-reviewers,Roger

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/b3167225bd7e