1985581 - riscv64: jit-test asm.js/testZOOB.js failed after Bug 1984978 Part 3 landed

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Rong Bao [:csmantle]]

jit-test asm.js/testZOOB.js failed on riscv64-simulator after Bug 1984978 Part 3 landed:

> ./mach jit-test -- -r ./testlist~
D:\Workspace\gecko-dev\js\src\jit-test\tests\asm.js/testZOOB.js:44:17 Error: Assertion failed: got 0, expected 1
Stack:
  testInt@D:\Workspace\gecko-dev\js\src\jit-test\tests\asm.js/testZOOB.js:44:17
  test@D:\Workspace\gecko-dev\js\src\jit-test\tests\asm.js/testZOOB.js:106:19
  @D:\Workspace\gecko-dev\js\src\jit-test\tests\asm.js/testZOOB.js:115:5
Exit code: 3
FAIL - asm.js\testZOOB.js
[1|1|0|1]  66% ===================================>                   |   1.3s
D:\Workspace\gecko-dev\js\src\jit-test\tests\asm.js/testZOOB.js:44:17 Error: Assertion failed: got 0, expected 1
Stack:
  testInt@D:\Workspace\gecko-dev\js\src\jit-test\tests\asm.js/testZOOB.js:44:17
  test@D:\Workspace\gecko-dev\js\src\jit-test\tests\asm.js/testZOOB.js:106:19
  @D:\Workspace\gecko-dev\js\src\jit-test\tests\asm.js/testZOOB.js:115:5
Exit code: 3
FAIL - asm.js\testZOOB.js
[1|2|0|1] 100% ======================================================>|   1.3s
FAILURES:
    asm.js\testZOOB.js
    --disable-wasm-huge-memory asm.js\testZOOB.js
TIMEOUTS:

See also https://ci.rvperf.org/job/Spidermonkey-upstream-fast-check/14969/console, around 33 jit-test failures can be observed on the latest main branch.

Bisect log

> git bisect log
git bisect start
# status: waiting for both good and bad commits
# bad: [856a307913c2b73765b4e88d32cf15ed05549cae] Revert "Bug 1982664 - Use std::make_unique_ptr instead of mozilla::MakeUniquePtr r=media-playback-reviewers,padenot" for causing fuzzing build bustages.
git bisect bad 856a307913c2b73765b4e88d32cf15ed05549cae
# status: waiting for good commit(s), bad commit known
# good: [d3e13e1d0f1ca39769afebc92838c9e11049fa1d] Bug 1980190 - [loong64] Port Bug 1975867 (Part 1) to loong64. r=rhunt
git bisect good d3e13e1d0f1ca39769afebc92838c9e11049fa1d
# good: [aa744f2075ffb4a14e157c5ce3b04f78e9dd37e4] Merge mozilla-central to autoland
git bisect good aa744f2075ffb4a14e157c5ce3b04f78e9dd37e4
# good: [4e94fcc76a025dff1a50181d085bd6de75e347dc] Bug 1983489 [wpt PR 54314] - webnn: make run tests supported by the context and mark labels, a=testonly
git bisect good 4e94fcc76a025dff1a50181d085bd6de75e347dc
# good: [5a1fbd9afa6f5bc46b7359e0faaef7efe4db9d45] Revert "Bug 1980812 - Avoid setting explicit h2 ALPN for connections, r=necko-reviewers,valentin" for causing xpc failures @ test_https_rr_ech_prefs.js
git bisect good 5a1fbd9afa6f5bc46b7359e0faaef7efe4db9d45
# bad: [d5cd1fe231304c4df8f72b331c297d869cb6da9d] Bug 1985133 - removed unused ioService access r=necko-reviewers,valentin
git bisect bad d5cd1fe231304c4df8f72b331c297d869cb6da9d
# good: [a0dd6a10ce6722f79465b836f542a020966b5e03] Revert "Bug 1971158, Bug 1973711, Bug 1976784, Bug 1978748: apply code formatting via Lando"
git bisect good a0dd6a10ce6722f79465b836f542a020966b5e03
# bad: [c28b9b0c424b5b38ae141305157496726c832404] Bug 1984818 - Improve the GetFuseState testing function. r=jandem
git bisect bad c28b9b0c424b5b38ae141305157496726c832404
# bad: [14bf9ed1fb4fcacf674a2ad49d48333164930145] Bug 1834395 - chore(webgpu): update bug ref. for `rgba16float` canvas texture format r=webgpu-reviewers,teoxoy
git bisect bad 14bf9ed1fb4fcacf674a2ad49d48333164930145
# good: [3a947f43662cd7fa45df29142128c89ff9c07a71] Bug 1941723 - Provide fieldsets and radio groups with AXHelp. r=Jamie
git bisect good 3a947f43662cd7fa45df29142128c89ff9c07a71
# good: [7a2289beca8d18c1a2367bd88540eb6fba524547] Bug 1984978 - Part 2: Implement {Add,Sub,Mul,Shift}IntPtr for Loong64. r=jandem
git bisect good 7a2289beca8d18c1a2367bd88540eb6fba524547
# bad: [b4f178aea31582229c0e738bbf5d9eb46adbe7bb] Bug 1981968 - Property bind the value attribute. r=tgiles
git bisect bad b4f178aea31582229c0e738bbf5d9eb46adbe7bb
# bad: [2c2f546cd7d3bc672e820d476ac86c35c046804c] Bug 1984978 - Part 3: Remove unnecessary and-instruction for shift-instructions. r=jandem
git bisect bad 2c2f546cd7d3bc672e820d476ac86c35c046804c
# first bad commit: [2c2f546cd7d3bc672e820d476ac86c35c046804c] Bug 1984978 - Part 3: Remove unnecessary and-instruction for shift-instructions. r=jandem
>

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1985581: Update shift instruction codegen to use shift amount in rhs register. r=jandem!

D262332 removed an unnecessary bit-and, but didn't update the dest uses to rhs.

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1984978

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8b2a7d4b99f3
https://hg.mozilla.org/integration/autoland/rev/56714a15c66f
Update shift instruction codegen to use shift amount in rhs register. r=jandem

Comment 4

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/56714a15c66f