1985715 - Bookmarks search doesn't work when Show search suggestions are turned off

Status: VERIFIED FIXED

(Firefox for Android :: Toolbar, defect)

Description

[Walter K.]

User Agent: Mozilla/5.0 (Android 10; Mobile; rv:144.0) Gecko/144.0 Firefox/144.0

Steps to reproduce:

1. Have some bookmarks saved
2. Turn off Show search suggestions in Settings->Search
3. Try searching for any part of the saved bookmarks in the address bar or via Bookmarks screen

Actual results:

No results are shown by Firefox suggest

Expected results:

All bookmarks that match search string should be displayed in the address bar dropdown.

This is a recent Nightly regression from 144 cycle. It affects both regular and private browsing modes.

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Firefox for Android::Search' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: SearchSuggestionsBanner.png

The issue comes from when we reimplemented this banner.
It was thought that this (and the setting that backs it) controls all search suggestions, but it only controls search suggestions from search engines.

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1972846

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1985715 - Show suggestions even if suggestions from the current search engine are disabled r=#android-reviewers

This comes to make a clearer distinction in code about what search suggestions mean
vs suggestions from the current search engine means
And ensure the user can see search suggestions even if suggestions from the current
search engines are disabled.

Comment 5

[Donal Meehan [:dmeehan]]

Tracking since there is a planned rollout in beta

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6249877a39b7
https://hg.mozilla.org/integration/autoland/rev/a144294838d7
Show suggestions even if suggestions from the current search engine are disabled r=android-reviewers,Roger

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a144294838d7

Comment 8

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:petru, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox143 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Adina Petridean QA [:apetridean]]

Attachment: video

Verified as fixed on the latest Nighlty 144.0a1 - 02.09.2025 using Samsung Galaxy S23 Ultra (Android 14).

Comment 11

[Adina Petridean QA [:apetridean]]

Attachment: Screen_Recording_20250902_171113_Firefox Nightly (1).mp4

Comment 12

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1985715 - Show suggestions even if suggestions from the current search engine are disabled r=#android-reviewers

This comes to make a clearer distinction in code about what search suggestions mean
vs suggestions from the current search engine means
And ensure the user can see search suggestions even if suggestions from the current
search engines are disabled.

Original Revision: https://phabricator.services.mozilla.com/D262977

Comment 13

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: No suggestions are shown if the user toggles off "Show search suggestions" from Settings
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: https://bugzilla.mozilla.org/show_bug.cgi?id=1985715#c0
• Risk associated with taking this patch: Low
• Explanation of risk level: Change verified by QA
• String changes made/needed: --
• Is Android affected?: yes

Comment 14

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/db8c0cf75183
https://hg.mozilla.org/releases/mozilla-beta/rev/0f8d941af9a3

Comment 15

[Mira Lobontiu (Android QA)]

Verified as fixed on the latest Firefox for Android Beta 143.0b8 with Samsung Galaxy Z Fold4 (Android 14), and a Google Pixel 3XL (Android 9).