Closed
Bug 1985761
Opened 3 months ago
Closed 3 months ago
Change SearchSuggestionController.fetch to take an object rather than individual arguments and improve TypeScript definitions for the local context
Categories
(Firefox :: Search, task, P2)
Firefox
Search
Tracking
()
RESOLVED
FIXED
144 Branch
| Tracking | Status | |
|---|---|---|
| firefox144 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Whiteboard: [sng])
Attachments
(1 file)
Starting to work on SearchSuggestions for bug 1984628, I wanted to add some more TypeScript definitions, especially around the context it stores.
When I started looking at that, I noticed the multiple parameter fetch, which is related to the context, and decided it would be clearer to change that to an object based parameter, rather the multiple parameters.
Updated•3 months ago
|
| Assignee | ||
Comment 1•3 months ago
|
||
Pushed by mbanner@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/0066e56e92e7
https://hg.mozilla.org/integration/autoland/rev/26d9e3aa61a2
Change SearchSuggestionController.fetch to take an object rather than individual arguments and improve TypeScript definitions for the local context. r=mcheang,home-newtab-reviewers,maxx
Comment 3•3 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
status-firefox144:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 144 Branch
Updated•3 months ago
|
QA Whiteboard: [search] [qa-triage-done-c144/b143]
You need to log in
before you can comment on or make changes to this bug.
Description
•