1985832 - Tab thumbnails never update to the latest painted version of the site

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect)

Description

[Jonathan Almeida [:jonalmeida]]

Attachment: reproducing the bug.mp4

Steps to reproduce

1. Open a lazy-loaded website (most React websites).
2. Refresh the page.
3. While refresh is occurring, open the tabs tray.
4. Observe.
5. After the page is done loading, open the tabs tray.
6. Observe.

Expected behaviour

• At step 4, the thumbnail is that of what was currently painted - a partial page load.
• At step 6, the thumbnail is that of what was currently painted - a full page load.

Actual behaviour

• At step 4, the thumbnail is that of what was currently painted - a partial page load.
• At step 6, the thumbnail is that of what was currently painted - the same partial page load.

Device information

• Firefox version: Nightly 144.0a1 (Build #2016110823), b7573b229c2d2e6a660decc4e3ed7183c761f8e1
  GV: 144.0a1-20250826095322
  AS: 144.20250822050345
• Android device model: Pixel 8a
• Android OS version: Android 16

Any additional information?

• This was previously implemented on the toolbar so that when we clicked the tab counter, we would update the thumbnail. This fixed the case for lazy-loading pages as well as for page scrolls that would mean the thumbnail needed to be updated during then as well.
• See attached video of the bug being reproduced.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

The tab counter can be clicked from both the toolbar, the navbar and the tabstrip.
A fix would have to cover all these scenarios.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Seems like the buttons are configured correctly

• for the tabstrip here
• for the composable toolbar here

But the issue affects the composable toolbar because of instantiating the composable toolbar first in BaseBrowserFragment#initializeUI and then the thumbnails feature in BrowserFragment#initializeUI.
There are multiple ways so improve the execution order of these.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1985832 - Lazy load the thumbnails feature in the composable toolbar r=#android-reviewers

This will give it enough time to be initialized before being used.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e9384c86cbc5
https://hg.mozilla.org/integration/autoland/rev/bc6aa2db9575
Lazy load the thumbnails feature in the composable toolbar r=android-reviewers,harrisono

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/bc6aa2db9575