1985946 - Verbose logs for mach lint aren't report logging from sub-processes

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P3)

Description

[Mark Banner (:standard8)]

This has been an issue for a while, though I've finally got around to investigating it. Running commands like the following only give the one line of output, and nothing from sub-processes.

% ./mach lint -l eslint toolkit/components/search -v
08:58:54.290 mozlint (49199) | setup for eslint finished in 0.3 seconds

Having dug around, the fix is to explicitly turn on logging for the sub-processes as well as the main process.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1985946 - Fix verbose logging from sub-processes when running 'mach lint'. r?#linter-reviewers!

This also adds some simple logging of exceptions raised from the sub-process. Whilst it doesn't cause the process to fail
it does at least mean the error is logged rather than thrown away.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9ef4411d1c7c
https://hg.mozilla.org/integration/autoland/rev/a852deab6e69
Fix verbose logging from sub-processes when running 'mach lint'. r=linter-reviewers,sylvestre

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a852deab6e69