1986157 - scrollbars in firefox beta and nightly are overlapped [windows 10/11 desktop]

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect)

Description

[DeJaVu_CF]

Attachment: buggy_scrollbar.png

Steps to reproduce:

open firefox w/o a new profile. set sidebar.revamp (in about:config) to false so we have the "old" sidebar. open sidebar with history or bookmarks that much that you get a scrollbar.

the scrollbar is overlapped, the width of sidebar is wrong calculated. its 3 pixel to wide. this also happens to web content

see issue (in german) here
https://www.camp-firefox.de/forum/thema/139771-firefox-v143-0beta6-fehler-mit-sidebar/

Actual results:

the scrollbar is overlapped, the width of sidebar is wrong calculated. its 3 pixel to wide. so the scrollbar is overlapped, the upper/lower arrows indicate this very good.

Expected results:

the scrollbar is in full width shown

Comment 1

[DeJaVu_CF]

Attachment: buggy_scrollbar2.png

another image

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Sidebar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Alice0775 White]

Regression window:
https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=4d571e1e4b6e71f60743da286154c44be8b900db&tochange=429ff7beb78edc627ba20497cf9bd2687490d7c3

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1979548

:emilio, since you are the author of the regressor, bug 1979548, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Does this happen only with sidebar.revamp = false?

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1986157 - Move inline margin to sidebar-launcher-splitter. r=#sidebar-reviewers

So that it doesn't apply to the regular splitter on the old sidebar.

Comment 7

[DeJaVu_CF]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #5)

Does this happen only with sidebar.revamp = false?

yes.

Comment 8

[DeJaVu_CF]

revamp = true
https://ibb.co/23kJ4D9S

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0ff143ded1b3
https://hg.mozilla.org/integration/autoland/rev/b2af0ae1ab58
Move inline margin to sidebar-launcher-splitter. r=desktop-theme-reviewers,dao,jsudiaman

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b2af0ae1ab58

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox143 to wontfix.

For more information, please visit BugBot documentation.

Comment 12

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9510542 [details]
Bug 1986157 - Move inline margin to sidebar-launcher-splitter. r=#sidebar-reviewers

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple CSS fix.
• String changes made/needed: none
• Is Android affected?: No

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9510542 [details]
Bug 1986157 - Move inline margin to sidebar-launcher-splitter. r=#sidebar-reviewers

Approved for 143.0b9.

Comment 14

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/9d1226774e7b
https://hg.mozilla.org/releases/mozilla-beta/rev/8113872e7985

Comment 15

[Peter Magyari (Desktop QA)]

Verified fixed using Nightly 144.0a1 (20250905010130) and Beta 143.0b9 (20250904161454) on Windows 10/11.