1986238 - Revert `instant` scroll behavior for "element.scrollIntoView()"

Status: RESOLVED FIXED

(Remote Protocol :: Agent, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As noticed on https://github.com/w3c/webdriver/issues/1923 the CSSOM removal of the instant scroll behavior was a mistake and got reverted in 2023. We missed that and never reverted this change. Also in Firefox we are now using auto since bug 1570605 landed, and should revert this change so that the instant behavior is always used again. Lets track this bug as a regression.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Upstream PR to revert the behavior is at https://github.com/w3c/webdriver/pull/1924.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

For creating a test case we could use the example from:
https://developer.mozilla.org/en-US/docs/Web/CSS/scroll-behavior#setting_smooth_scroll_behavior

The scroll behavior could be set to smooth which is then inherited by scrollIntoView() and should cause the element to be scrolled into the viewport with a delay. At least for element click we should be able to validate that a click as done immediately after calling that method is not reaching the actual target element. Forcing instant should then do it correctly.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1986238 - [wdspec] Update tests for scroll into view with behavior instant.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1986238 - [remote] Revert scrollIntoView behavior to "instant".

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3ab78e3418a7
https://hg.mozilla.org/integration/autoland/rev/f50ed5ad3339
[remote] Revert scrollIntoView behavior to "instant". r=webdriver-reviewers,Sasha
https://github.com/mozilla-firefox/firefox/commit/fcc6bc22cd30
https://hg.mozilla.org/integration/autoland/rev/0b5fcf6cf90a
[wdspec] Update tests for scroll into view with behavior instant. r=webdriver-reviewers,Sasha

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I don't think it makes sense to get it fixed for esr 115 and 128 which will soon be no longer supported.

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/54721 for changes under testing/web-platform/tests

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f50ed5ad3339
https://hg.mozilla.org/mozilla-central/rev/0b5fcf6cf90a

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Given that no one complained about it yet lets not immediately uplift. If there will be reports by users and they have to rely on ESR 140 we can consider uplifting the patch.