1986309 - #inner-navigate-event-firing-algorithm needs to wait on committed promise for failure steps as well

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Comment 1

[Andreas Farre [:farre]]

Attachment: Bug 1986309 - Always wait on committed promise if there is an api method tracker. r=jjaschke!

It turns out that we need this to guarantee event ordering with regard
to promises resolving and rejecting. This means that not only does the
success steps need to wait on method tracker committed promise, so does
the failure steps. But not only that, if we have handlers in the promise
list we need to really ensure that their promises are handled after a
committed promise.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/047ca4924920
https://hg.mozilla.org/integration/autoland/rev/4194fd410666
Always wait on committed promise if there is an api method tracker. r=jjaschke

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/08e663da3374
https://hg.mozilla.org/integration/autoland/rev/fe265da7b601
Revert "Bug 1986309 - Always wait on committed promise if there is an api method tracker. r=jjaschke" for causing build bustages at Navigation.cpp

Comment 4

[Cristina Horotan [:chorotan]]

Backed out for causing build bustages at Navigation.cpp

Backout link

Push with failures

Failure log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d6b7921aa6dd
https://hg.mozilla.org/integration/autoland/rev/855fcb2cc6a4
Always wait on committed promise if there is an api method tracker. r=jjaschke

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/855fcb2cc6a4