1986320 - Implement an add-on block URL-Classifier feature

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, task)

Description

[Andrea Marchesini [:baku]]

Introduce a new URL Classifier protection feature (addon-protection) that cancels network requests initiated by WebExtensions when the request URL matches a Mozilla-managed blocklist.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: (secure)

Comment 2

[Andrea Marchesini [:baku]]

Attachment: (secure)

Comment 3

[Andrea Marchesini [:baku]]

Attachment: (secure)

Comment 4

[Andrea Marchesini [:baku]]

Attachment: (secure)

Comment 5

[Andrea Marchesini [:baku]]

Attachment: (secure)

Comment 6

[Andrea Marchesini [:baku]]

Attachment: (secure)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1ef88130d9c3
https://hg.mozilla.org/integration/autoland/rev/4bb878404928
Implement an add-on block URL-Classifier feature - part 1, r=dimi,geckoview-reviewers,extension-reviewers,tcampbell,robwu
https://github.com/mozilla-firefox/firefox/commit/2a13eb6ec3e8
https://hg.mozilla.org/integration/autoland/rev/10c2c2d07ad2
Implement an add-on block URL-Classifier feature - part 2 - telemetry, r=dimi,extension-reviewers,robwu
https://github.com/mozilla-firefox/firefox/commit/928a253e9e58
https://hg.mozilla.org/integration/autoland/rev/9cbc1479a8d0
Implement an add-on block URL-Classifier feature - part 3 - devtool support, r=devtools-reviewers,dimi,devtools-backward-compat-reviewers,bomsy
https://github.com/mozilla-firefox/firefox/commit/1e7b1753d4f3
https://hg.mozilla.org/integration/autoland/rev/6033ed4ed14f
Implement an add-on block URL-Classifier feature - part 4 - Expose the URLClassifier addon feature to non-recommended addons only, r=zombie
https://github.com/mozilla-firefox/firefox/commit/5f2e690d2b87
https://hg.mozilla.org/integration/autoland/rev/18e9d726a767
Implement an add-on block URL-Classifier feature - part 5 - Block top-level documents when loaded by add-ons, r=extension-reviewers,dimi,fluent-reviewers,robwu,bolsson,android-reviewers,android-l10n-reviewers,delphine,tcampbell
https://github.com/mozilla-firefox/firefox/commit/768f3614fff2
https://hg.mozilla.org/integration/autoland/rev/1715e2ded349
apply code formatting via Lando

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f1a3613f4487
https://hg.mozilla.org/integration/autoland/rev/fbd4b479828d
Implement an add-on block URL-Classifier feature - part 1, r=dimi,geckoview-reviewers,extension-reviewers,tcampbell,robwu
https://github.com/mozilla-firefox/firefox/commit/1bdba2f4267b
https://hg.mozilla.org/integration/autoland/rev/53238d80f8d0
Implement an add-on block URL-Classifier feature - part 2 - telemetry, r=dimi,extension-reviewers,robwu
https://github.com/mozilla-firefox/firefox/commit/c0f866931b7f
https://hg.mozilla.org/integration/autoland/rev/a2bbe4044378
Implement an add-on block URL-Classifier feature - part 3 - devtool support, r=devtools-reviewers,dimi,devtools-backward-compat-reviewers,bomsy
https://github.com/mozilla-firefox/firefox/commit/41e8a464d964
https://hg.mozilla.org/integration/autoland/rev/f5712b887e8e
Implement an add-on block URL-Classifier feature - part 4 - Expose the URLClassifier addon feature to non-recommended addons only, r=zombie
https://github.com/mozilla-firefox/firefox/commit/9a058ba0d546
https://hg.mozilla.org/integration/autoland/rev/4d227a881fc4
Implement an add-on block URL-Classifier feature - part 5 - Block top-level documents when loaded by add-ons, r=extension-reviewers,dimi,fluent-reviewers,robwu,bolsson,android-reviewers,android-l10n-reviewers,delphine,tcampbell
https://github.com/mozilla-firefox/firefox/commit/7b0c7db7c391
https://hg.mozilla.org/integration/autoland/rev/c53aaddf7c20
Implement an add-on block URL-Classifier feature - part 6 - Mobile r=geckoview-reviewers,android-reviewers,geckoview-api-reviewers,tcampbell,ohall
https://github.com/mozilla-firefox/firefox/commit/8c2c577a0300
https://hg.mozilla.org/integration/autoland/rev/22b92a6b9637
apply code formatting via Lando

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c99c2717306a
https://hg.mozilla.org/integration/autoland/rev/4739d57a40aa
Revert "Bug 1986320: apply code formatting via Lando" for causing lint failures in browser_ext_urlclassifier.js

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/22df59379f28
https://hg.mozilla.org/integration/autoland/rev/85258411f49a
Implement an add-on block URL-Classifier feature - part 1, r=dimi,geckoview-reviewers,extension-reviewers,tcampbell,robwu
https://github.com/mozilla-firefox/firefox/commit/a742b6bf8a4b
https://hg.mozilla.org/integration/autoland/rev/a5fbdff75d86
Implement an add-on block URL-Classifier feature - part 2 - telemetry, r=dimi,extension-reviewers,robwu
https://github.com/mozilla-firefox/firefox/commit/23f4d7c6588a
https://hg.mozilla.org/integration/autoland/rev/7fa45743d448
Implement an add-on block URL-Classifier feature - part 3 - devtool support, r=devtools-reviewers,dimi,devtools-backward-compat-reviewers,bomsy
https://github.com/mozilla-firefox/firefox/commit/4ae3a234fbea
https://hg.mozilla.org/integration/autoland/rev/9d2bcad7c3cd
Implement an add-on block URL-Classifier feature - part 4 - Expose the URLClassifier addon feature to non-recommended addons only, r=zombie
https://github.com/mozilla-firefox/firefox/commit/985c5a4d6619
https://hg.mozilla.org/integration/autoland/rev/ea5a37dfadcb
Implement an add-on block URL-Classifier feature - part 5 - Block top-level documents when loaded by add-ons, r=extension-reviewers,dimi,fluent-reviewers,robwu,bolsson,android-reviewers,android-l10n-reviewers,delphine,tcampbell
https://github.com/mozilla-firefox/firefox/commit/1dfcfb33ff21
https://hg.mozilla.org/integration/autoland/rev/0d726adda97e
Implement an add-on block URL-Classifier feature - part 6 - Mobile r=geckoview-reviewers,android-reviewers,geckoview-api-reviewers,tcampbell,ohall
https://github.com/mozilla-firefox/firefox/commit/d6a3a654e47e
https://hg.mozilla.org/integration/autoland/rev/6f79dabce899
apply code formatting via Lando

Comment 11

[Ted Campbell [:tcampbell]]

The test-verify intermittent is probably worth addressing as follow-up https://treeherder.mozilla.org/jobs?repo=autoland&fromchange=b8e306c17220af4d7cc8a85215bb3abdffbed81d&selectedTaskRun=BGMREulHR0q1Qqdzc_6K1w.0

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/85258411f49a
https://hg.mozilla.org/mozilla-central/rev/a5fbdff75d86
https://hg.mozilla.org/mozilla-central/rev/7fa45743d448
https://hg.mozilla.org/mozilla-central/rev/9d2bcad7c3cd
https://hg.mozilla.org/mozilla-central/rev/ea5a37dfadcb
https://hg.mozilla.org/mozilla-central/rev/0d726adda97e
https://hg.mozilla.org/mozilla-central/rev/6f79dabce899

Comment 13

[Andrea Marchesini [:baku]]

Attachment: request.md

Comment 14

[Chris H-C :chutten]

Comment on attachment 9533863 [details]
request.md

Default-on collection of Category 3 data requires the Sensitive Data Collection Review process (basically an email thread) as Data Stewards are unable to quickly/obviously assert that the collection is within policy.

data-review- pending Sensitive Data Collection Review

Comment 15

[Mike Kaply [:mkaply]]

For future reference, I should be a reviewer on any changes to Policies or at least notified about them so they can be documented.

What should be said about this in the policy documentation?

Comment 16

[Andrea Marchesini [:baku]]

Last time I spoke with Legal this policy change was not required.

Comment 17

[Mike Kaply [:mkaply]]

I meant enterprise policies. There was code added for this to enterprise policies that needs to be documented.

Comment 18

[Mike Kaply [:mkaply]]

And actually, the change to Policies.sys.mjs won't work at all because the policies-schema wasn't updated.

Comment 19

[Rob Wu [:robwu]]

(In reply to Mike Kaply [:mkaply] from comment #18)

And actually, the change to Policies.sys.mjs won't work at all because the policies-schema wasn't updated.

Filed bug 2018964 as a follow-up.