Closed
Bug 1986329
Opened 9 months ago
Closed 9 months ago
Rename one gFlags variable to avoid unified build issues
Categories
(Core :: Layout, task)
Core
Layout
Tracking
()
RESOLVED
FIXED
144 Branch
| Tracking | Status | |
|---|---|---|
| firefox144 | --- | fixed |
People
(Reporter: jari, Assigned: jari)
Details
Attachments
(1 file)
Variable name gFlags is currently in use for global flags at layout/base/PresShell.cpp, layout/base/nsCSSFrameConstructor.cpp and layout/generic/nsBlockFrame.cpp. Because the two first ones are both under layout/base folder, the unified build may fail sometimes especially together with the auto keyword. Giving one of them a more specific name would protect us from this scenario.
|
Assignee | |
Comment 1•9 months ago
|
||
|
||
Updated•9 months ago
|
Assignee: nobody → jjalkanen
Status: NEW → ASSIGNED
Pushed by jjalkanen@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/a3f3e59e40c2
https://hg.mozilla.org/integration/autoland/rev/617f2abcd747
Rename one gFlags variable to avoid unified build issues. r=layout-reviewers,emilio
|
||
Comment 3•9 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
status-firefox144:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 144 Branch
|
||
Updated•8 months ago
|
QA Whiteboard: [qa-triage-done-c145/b144]
You need to log in
before you can comment on or make changes to this bug.
Description
•