Closed Bug 1986392 Opened 1 month ago Closed 2 days ago

"WebDriver:GetElementText" fails to correctly capitalize text containing accent characters ("ó")

Categories

(Remote Protocol :: Marionette, defect, P3)

defect
Points:
2

Tracking

(firefox-esr115 unaffected, firefox-esr128 wontfix, firefox-esr140 fix-optional, firefox142 wontfix, firefox143 wontfix, firefox144 wontfix, firefox145 wontfix, firefox146 fixed)

RESOLVED FIXED
146 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- wontfix
firefox-esr140 --- fix-optional
firefox142 --- wontfix
firefox143 --- wontfix
firefox144 --- wontfix
firefox145 --- wontfix
firefox146 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [webdriver:m18], [wptsync upstream])

Attachments

(2 files)

With the changes from bug 1888004 another bug in the bot.dom.getVisibleText() Selenium atom was revealed. This time for accent characters. The issue was filed as https://github.com/SeleniumHQ/selenium/issues/14271 and now got fixed in Selenium. Here a HTML testcase that we could use in a wdspec test:

<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <title>Bug Test</title>
    <style>
        h1 {
            text-transform: capitalize;
        }
    </style>
</head>
<body>
    <h1>Fecha de expiración</h1>
</body>
</html>

The output should be Fecha De Expiración but it ends-up with Fecha De ExpiraciÓN.

We should agree on updating the bot.dom.getVisibleText() Selenium atom in the WebDriver classic specification to https://github.com/SeleniumHQ/selenium/commit/775cfb33b193eb8832cd5488f298006f45254685 and ensure that nothing else is broken.

Severity: -- → S3
Points: --- → 3
Priority: -- → P3
Whiteboard: [webdriver:m18]
Points: 3 → 2

I tried to build the Selenium atoms but it's currently failing due to https://github.com/SeleniumHQ/selenium/issues/16358.

I was able to solve the problems with building the atoms. I'll take a look today or when I'm back.

Assignee: nobody → hskupin
Status: NEW → ASSIGNED

It looks to be all fine locally for me. No regression seen when updating the Selenium atoms. But to be sure I've triggered a try build:
https://treeherder.mozilla.org/jobs?repo=try&revision=0cd224d56e638d6fe31bbe203600880d068b2356

I'm going to file a WebDriver classic issue now to update to the 775cfb33b193eb8832cd5488f298006f45254685 revision of Selenium atoms.

The WebDriver classic spec PR can be found at https://github.com/w3c/webdriver/pull/1932.

Pushed by hskupin@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/3b29ae0539fc https://hg.mozilla.org/integration/autoland/rev/717ca8bc5afe Update Selenium atoms to revision 775cfb33b193eb8832cd5488f298006f45254685. r=webdriver-reviewers-rotation,Sasha https://github.com/mozilla-firefox/firefox/commit/896dd2040288 https://hg.mozilla.org/integration/autoland/rev/cf6771047c21 [wdspec] Add test for "Element Get Text" with accent character. r=webdriver-reviewers-rotation,Sasha
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/55708 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m18] → [webdriver:m18], [wptsync upstream]
Status: ASSIGNED → RESOLVED
Closed: 2 days ago
Resolution: --- → FIXED
Target Milestone: --- → 146 Branch

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

We are late in the beta cycle and the merge to release will happen soon. As such I don't think that we should uplift this change but give it a full nightly cycle to bake. If it's stable we could think about an uplift to esr140 at a later point. I'll check back once 146 is on release.

Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: