Closed Bug 1986398 Opened 4 months ago Closed 3 months ago

Add fallback behaviour when the custom review prompt is not shown, but no error is returned

Categories

(Firefox for Android :: Onboarding, task)

Product:
Firefox for Android
Component:
Onboarding
Platform:
All
Android
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
146 Branch
Tracking Flags:
Tracking Status
firefox146 --- fixed

People

(Reporter: mkozinski, Assigned: mkozinski)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid][group2])

Attachments

(2 files)

Bug 1986398 - Refactor recordReviewPromptEvent to extract determining if prompt was displayed
48 bytes, text/x-phabricator-request
Details | Review
Bug 1986398 - Add fallback behavior when the custom review prompt is not shown without any errors
48 bytes, text/x-phabricator-request
Details | Review

Handle the flow whenrequestReviewFlow task is successful, but the prompt isn't shown anyway. recordReviewPromptEvent() has information both in documentation and in code on how to try to detect this scenario. In this case we should fall back to opening the play store, same as in the error case.

Pushed by mkozinski@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/e01fd2f0dd2b https://hg.mozilla.org/integration/autoland/rev/324d5fdb2c6e Refactor recordReviewPromptEvent to extract determining if prompt was displayed r=android-reviewers,twhite https://github.com/mozilla-firefox/firefox/commit/068342661716 https://hg.mozilla.org/integration/autoland/rev/f857eccb3b35 Add fallback behavior when the custom review prompt is not shown without any errors r=android-reviewers,twhite

https://hg.mozilla.org/mozilla-central/rev/324d5fdb2c6e
https://hg.mozilla.org/mozilla-central/rev/f857eccb3b35

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
status-firefox144: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 144 Branch
See Also: → 1992091
Regressions: 1992436

Requesting to back this out of beta and main, because of the linked regression.

Flags: needinfo?(ryanvm)
Pushed by chorotan@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/da7a647e48e4 https://hg.mozilla.org/mozilla-central/rev/c8f9e8584155 Revert "Bug 1986398 - Add fallback behavior when the custom review prompt is not shown without any errors r=android-reviewers,twhite" on request

Backed out from central: https://hg.mozilla.org/mozilla-central/rev/c8f9e8584155d95a1d44eb7fba91d39c22941aa0

Status: RESOLVED → REOPENED
status-firefox144: fixed → ---
Flags: needinfo?(mkozinski)
Resolution: FIXED → ---
Target Milestone: 144 Branch → ---
Flags: needinfo?(ryanvm)
See Also: → 1992849
Regressions: 1992849
Blocks: review-prompt-followups
No longer blocks: review-prompt
Flags: needinfo?(mkozinski)
Pushed by mkozinski@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/63d556f30e3a https://hg.mozilla.org/integration/autoland/rev/a3a937d1c277 Refactor recordReviewPromptEvent to extract determining if prompt was displayed r=android-reviewers,twhite https://github.com/mozilla-firefox/firefox/commit/70fb25dd2051 https://hg.mozilla.org/integration/autoland/rev/8b402f1b4360 Add fallback behavior when the custom review prompt is not shown without any errors r=android-reviewers,twhite

https://hg.mozilla.org/mozilla-central/rev/a3a937d1c277
https://hg.mozilla.org/mozilla-central/rev/8b402f1b4360

Status: REOPENED → RESOLVED
Closed: 4 months ago → 3 months ago
status-firefox146: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 146 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: