1986534 - Disable screenshots in PBM

Status: RESOLVED FIXED

(Firefox for Android :: Privacy, task)

Comment 1

[John Oberhauser]

Attachment: Bug 1986534 - Part 1: Disable app preview in recents if the user is in private browsing mode

Comment 2

[John Oberhauser]

Attachment: Bug 1986534 - Part 2: Removing old code for preventing screenshots in PBM

Comment 3

[John Oberhauser]

Attachment: Bug 1986534 - Part 3: Deleting unused classes

Comment 4

[John Oberhauser]

Attachment: Bug 1986534 - Part 4: Removing the 'allow screenshots in private mode' setting

Comment 5

[John Oberhauser]

Attachment: Bug 1986534 - Part 5: Deleting old strings

Comment 6

[Mike a [:mavduevskiy]]

adding a bit of context here (had to dig into slack threads)

Now that we can separate hiding in app switcher and allowing screenshots, to simply even further, we could keep the allow screenshots ON by default, and not provide setting to turn it off. So remove the setting completely. While keeping the tab view switched OFF when using app switcher by default in PBM.
With this simplification, the aim is to reduce the number of settings in the app. We could wait for telemetry probe to see how many people actually have the allow screenshots turned ON.

Comment 7

[John Oberhauser]

Attachment: WIP: Bug 1986534 - Part 6: testing other methods

Comment 8

[John Oberhauser]

product has decided we should just disable all screenshotting in PBM

Comment 9

[John Oberhauser]

Attachment: Bug 1986534 - Removing allow screenshots in private mode option

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/92182b35b9b5
https://hg.mozilla.org/integration/autoland/rev/9b2e4c889503
Removing allow screenshots in private mode option r=android-reviewers,android-l10n-reviewers,delphine,rebecatudor273

Comment 11

[amarc]

https://hg.mozilla.org/mozilla-central/rev/9b2e4c889503

Comment 12

[Donal Meehan [:dmeehan]]

John, could you consider nominating this change for a release note? (Process info)

Comment 13

[John Oberhauser]

Release Note Request (optional, but appreciated)
[Why is this notable]: A feature is being removed that may adversely affect some user's experience.
[Affects Firefox for Android]: The option to allow screenshots in private browsing mode has been removed.
[Suggested wording]: The option to allow screenshots in private browsing mode has been removed.
[Links (documentation, blog post, etc)]:

Comment 14

[Donal Meehan [:dmeehan]]

Thanks, added to the Fx144 nightly release notes, please allow 30 minutes for the site to update.
Keeping the relnote-firefox flag as ? to keep it on the radar for inclusion in the final Fx144 release notes.

Comment 15

[Sören Hentzschel]

I suggest mentioning the motivation for the removal in the release notes. We know from past experience that it is always a problem in the public perception when options are removed. And this can at least be mitigated somewhat by explaining the reason.

(Especially since your release notes generally don't mention many improvements. The release notes for Firefox 142 for Android, for example, didn't mention a single new feature (the only mentioned improvement was already mentioned for Firefox 141), even though I know from writing my article about Firefox 142 that Firefox 142 for Android did indeed bring quite a few noteworthy improvements. If you don't mention any improvements, removals are potentially perceived even more negative from the user's POV.)

edit: self-marking my comment as obsolete as the change was backed out.

Comment 16

[Donal Meehan [:dmeehan]]

Keeping the ? flag to help track removing the note from beta

Comment 17

[Donal Meehan [:dmeehan]]

Rejecting the Fx144 release note request, reverted in Bug 1989155 from Beta.
Removed from the Fx144 Beta release notes.