Closed
Bug 1986545
Opened 3 months ago
Closed 1 month ago
Use PluralForm for known networks in cZ
Categories
(SeaMonkey :: Chat, enhancement)
SeaMonkey
Chat
Tracking
(seamonkey2.53? affected)
RESOLVED
FIXED
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
(Whiteboard: SM2.53.23)
Attachments
(1 file)
|
3.13 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
At the moment we use the string:
%1$S known networks (%2$S connected)
It would be better if we used PluralForm.jsm so that locales with multiple plural forms can properly localise.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: some locales may have poor localisations
Testing completed (on m-c, etc.): 2.53.22pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: 1 removal, 1 addition
Attachment #9510971 -
Flags: review?(frgrahl)
Attachment #9510971 -
Flags: approval-comm-release?
|
||
Comment 2•1 month ago
|
||
Comment on attachment 9510971 [details] [diff] [review]
1986545-irc-plural-networks-25322.patch
LGTM r/a+
Attachment #9510971 -
Flags: review?(frgrahl)
Attachment #9510971 -
Flags: review+
Attachment #9510971 -
Flags: approval-comm-release?
Attachment #9510971 -
Flags: approval-comm-release+
|
|
||
Updated•1 month ago
|
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/ca59046870ef
Use PluralForm for known networks in cZ. r=frg DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•