1986774 - `moz-phab` appends Phabricator revision links are with LF, even if the original revision message uses CRLF

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect)

Description

[Erich Gubler [:ErichDonGubler] (he/him)]

moz-phab version (from moz-phab version): 2.4.1 (but reproducible for…a long time!)

Steps to reproduce

1. File a patch using moz-phab from Windows.
2. View the contents of the revision message using your VCS, i.e., git show, hg show, jj show using an application that clearly signals line endings being used. Observe that CRLF is used for all lines, except for an LF (no carriage return) before the line with the Differential Revision: … message trailer.

Comment 1

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1986774 - fix(submit): unconditionally use LF for rewritten rev. messages r=sheehan

Comment 2

[BMO Github Automation]

Authored by https://github.com/ErichDonGubler
https://github.com/mozilla-conduit/review/commit/dcd37c5d251410afe557dfbdbaf063db5bd017d3
[main] Bug 1986774 - fix(submit): unconditionally use LF for rewritten rev. messages r=sheehan