1986838 - Disable `contentreadonly` and `insertbronreturn` edit commands in all channels

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

They were disabled in early beta and earlier builds 4 years ago, and no bug reports from beta/nightly testers. So, I think we can disable them in all channels.

Although I don't get the latest data of the usage, but when I was working on that 4 years ago, there were a lot of queries of state of the commands. I guess that they are used for finger printing because disabling the commands has not cause getting regression reports.

Additionally, executing the commands cause changing the HTMLEditor's basic behavior but the other browsers do not support them. So, I guess only the bool result of execCommand is used for finger printing. I cannot imagine how to use the commands for editable web apps which can be used in any browsers.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1986838 - Disable the legacy edit command, `contentReadOnly` and `insertBrOnReturn` in all channels r=smaug!,#dom-core

They are disabled in early beta and earlier builds 4 years ago.
However, we don't get any regression reports. Although the use counters
say they are still used both execCommand and query their state. I
guess they are used for finger printing because executing the commands
change the behavior of HTMLEditor and the result is not compatible
with the other browsers. So, it's hard to guess that how to use them
in editable web apps to control our HTMLEditor.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6a17f01e42f5
https://hg.mozilla.org/integration/autoland/rev/3cda49391a4c
Disable the legacy edit command, `contentReadOnly` and `insertBrOnReturn` in all channels r=smaug,dom-core

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Posted to dev-platform: https://groups.google.com/a/mozilla.org/g/dev-platform/c/n8qWKbiV7to

Comment 4

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/3cda49391a4c

Comment 5

[Sebastian Zartner [:sebo]]

This removal should at least be noted in the release notes for Firefox 144. And the related BCD for execCommand() should be updated (even when execCommand() itself is already marked as deprecated). As the pages of the related methods queryCommandEnabled(), queryCommandState() and queryCommandSupported() refer to execCommand() for the individual commands, they probably don't need any updates.

Sebastian