1986890 - Support "add engine" badge on the unified search button

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Dão Gottwald [:dao]]

For the search bar, we'll likely want to display the "add engine" badge on the button when a web page offers an engine.

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1986890 - Show the "add engine" badge on the unified search button of the new search bar. r=daleharvey

The old search bar (browser.search.widget.new=false) badges its search button
when the current page offers an opensearch engine. Do the same for the new
search bar's unified search button, driven from the same OpenSearchManager path
that already updates the old search bar.

The badge is scoped to the search bar; the address bar's unified search button
stays unbadged, matching the old behavior.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0e283f94bbe9
https://hg.mozilla.org/integration/autoland/rev/92d08efec462
Show the "add engine" badge on the unified search button of the new search bar. r=daleharvey

Comment 4

[Silaghi Andreea]

Backed out for causing build bustages
Backout Link
Push with failures
Failure Log
Failure line Error processing test manifest file /builds/worker/checkouts/gecko/browser/components/urlbar/tests/browser/searchbar/browser.toml: Traceback (most recent call last):

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/16e8979074c6
https://hg.mozilla.org/integration/autoland/rev/5278b4c30fe4
Show the "add engine" badge on the unified search button of the new search bar. r=daleharvey

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/16a3d8ab97fe
https://hg.mozilla.org/integration/autoland/rev/802369548217
Revert "Bug 1986890 - Show the "add engine" badge on the unified search button of the new search bar. r=daleharvey" for causing doc generate failures

Comment 7

[Silaghi Andreea]

Backed out for causing doc generate failures
Backout Link
Push with failures
Failure Log
Failure line sphinx.errors.ExtensionError: Handler <function analyze at 0x7f242fbdaca0> for event 'builder-inited' threw an exception (exception: Your code contains multiple documented objects at each of these paths:

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/121994d3fa97
https://hg.mozilla.org/integration/autoland/rev/530da3d51cd5
Show the "add engine" badge on the unified search button of the new search bar. r=daleharvey

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/530da3d51cd5

Comment 10

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2026-07-27 Firefox Nightly build on Windows 10.

Verified as fixed on Firefox Nightly 158.0a1 and Firefox 157.0b5 on Windows 10, Ubuntu 22, macOS 13.