1986946 - Add context menu entry point for split view, and handle the single tab and multi-selected cases

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser: Split View, enhancement, P1)

Description

[Stuart Colville [:muffinresearch]]

Handle the single selected tab case (create new tab and add that to split view) and add a tab context menu entry point (behind a pref)

Comment 1

[Sarah Clements [:sclements]]

Requirements are on page 3 including if a tab is pinned we don't show the "Add to split view" options.

Comment 2

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1986946 - Add context menu entry point for split view, and handle the single tab and multi-selected cases

Comment 3

[Kelly Cochrane [:kcochrane]]

Please note that the "New" badge for the new context menu options will display as grey on mac and green on Win/Linux

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/af815ad82355
https://hg.mozilla.org/integration/autoland/rev/6a1bd67a02e2
Add context menu entry point for split view, and handle the single tab and multi-selected cases r=tabbrowser-reviewers,fluent-reviewers,jsudiaman,flod,sthompson,sclements,desktop-theme-reviewers,sfoster

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/825551cdbca9
https://hg.mozilla.org/integration/autoland/rev/f2668214fbcc
Revert "Bug 1986946 - Add context menu entry point for split view, and handle the single tab and multi-selected cases r=tabbrowser-reviewers,fluent-reviewers,jsudiaman,flod,sthompson,sclements,desktop-theme-reviewers,sfoster" for causing bc failures @browser_tab_splitview.js.

Comment 6

[Goloman Adrian[:agoloman]]

Backed out for causing bc failures @browser_tab_splitview.js.

• Backout link
• Push with failures
• Failure Log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0f7b9bd615a8
https://hg.mozilla.org/integration/autoland/rev/bf6b8a019ebf
Add context menu entry point for split view, and handle the single tab and multi-selected cases r=tabbrowser-reviewers,fluent-reviewers,jsudiaman,flod,sthompson,sclements,desktop-theme-reviewers,sfoster

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/bf6b8a019ebf

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2c941048716c
https://hg.mozilla.org/integration/autoland/rev/4f933461ddfd
Revert "Bug 1986946 - Add context menu entry point for split view, and handle the single tab and multi-selected cases r=tabbrowser-reviewers,fluent-reviewers,jsudiaman,flod,sthompson,sclements,desktop-theme-reviewers,sfoster" for bc failure on browser_tab_splitview.js

Comment 10

[Narcis Beleuzu [:NarcisB]]

Backed out for causing bc failure on browser_tab_splitview.js

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/4f933461ddfdf75248d13271408dc7730993eb4d
Log link: https://treeherder.mozilla.org/logviewer?job_id=531314322&repo=autoland&task=BUMOySSNR36AMDcUUEszwA.0&lineNumber=8695

Comment 11

[amarc]

backout merged to central: https://hg.mozilla.org/mozilla-central/rev/4f933461ddfd

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7bcabe02b22c
https://hg.mozilla.org/integration/autoland/rev/26aeb664e208
Add context menu entry point for split view, and handle the single tab and multi-selected cases r=tabbrowser-reviewers,fluent-reviewers,jsudiaman,flod,sthompson,sclements,desktop-theme-reviewers,sfoster

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2507c0ddee0e
https://hg.mozilla.org/integration/autoland/rev/c9dd6d5f66a0
Revert "Bug 1986946 - Add context menu entry point for split view, and handle the single tab and multi-selected cases r=tabbrowser-reviewers,fluent-reviewers,jsudiaman,flod,sthompson,sclements,desktop-theme-reviewers,sfoster" for causing bc failures on nsMenuPopupFrame.cpp

Comment 14

[Cristina Horotan [:chorotan]]

Backed out for causing bc failures on nsMenuPopupFrame.cpp

Backout link

Push with failures

Failure log

Comment 15

[Florin Bilt]

(In reply to Pulsebot from comment #5)

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/825551cdbca9
https://hg.mozilla.org/integration/autoland/rev/f2668214fbcc
Revert "Bug 1986946 - Add context menu entry point for split view, and
handle the single tab and multi-selected cases
r=tabbrowser-reviewers,fluent-reviewers,jsudiaman,flod,sthompson,sclements,
desktop-theme-reviewers,sfoster" for causing bc failures
@browser_tab_splitview.js.

Perfherder has detected a browsertime performance change from push f2668214fbcca73e547d841de8db4e4a3f91b411.

If you have any questions, please reach out to a performance sheriff. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
7%	welcome fcp	linux1804-64-shippable-qr	cold fission webrender	121.08 -> 112.72	Before/After

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a performance sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 47088

The following documentation link provides more information about this command.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e1539b74844d
https://hg.mozilla.org/integration/autoland/rev/d4923e2a277e
Add context menu entry point for split view, and handle the single tab and multi-selected cases r=tabbrowser-reviewers,fluent-reviewers,jsudiaman,flod,sthompson,sclements,desktop-theme-reviewers,sfoster

Comment 17

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/d4923e2a277e