1987010 - Test ERROR because "from PIL import Image" after importing testdriver.js

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[Boris Chiou [:boris]]

This happened when I was trying to debug these two wpt tests on local machine.

1. https://searchfox.org/firefox-main/source/testing/web-platform/tests/css/css-view-transitions/hit-test-unrelated-element.html
2. https://searchfox.org/firefox-main/source/testing/web-platform/tests/css/css-view-transitions/hit-test-unpainted-element.html

I always saw the error message like this:

Error Summary
-------------
ERROR /css/css-view-transitions/hit-test-unrelated-element.html - Traceback (most recent call last):
  File "/Users/boris/Projects/firefox/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/executors/base.py", line 322, in run_test
    result = self.do_test(test)
  File "/Users/boris/Projects/firefox/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/executors/executormarionette.py", line 1167, in do_test
    result = self.implementation.run_test(test)
  File "/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/executors/base.py", line 550, in run_test
    is_pass, page_idx = self.check_pass(hashes, screenshots, urls, relation, fuzzy)
                        ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/executors/base.py", line 472, in check_pass
    max_per_channel, pixels_different = self.get_differences(comparison_screenshots,
                                        ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
                                                             urls,
                                                             ^^^^^
                                                             page_idx if len(hashes) > 1 else None)
                                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/executors/base.py", line 493, in get_differences
    from PIL import Image, ImageChops, ImageStat
ModuleNotFoundError: No module named 'PIL'

After I removed the usage of test_driver and /resources/testdriver.js, the error disappeared.
I cannot just pip3 install Image on my machine because it seems I have to tweak the virtual environment for wpt.

Comment 1

[Boris Chiou [:boris]]

HI James,

I noticed you move this line (i.e. from PIL import Image) in Bug 1539181. It seems we have to use this module now in WPT. Is there any easy way to fix this test error on local machine? This happened on both mac and linux, and TYLin can reproduce this issue on his local machine (mac and linux).

Comment 2

[James Graham [:jgraham]]

Attachment: Bug 1987010 - Install Pillow in wpt virtualenv,

This is required to run reftests which depend on testdriver.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/15f34c4274c1
https://hg.mozilla.org/integration/autoland/rev/5fbd3c3edee2
Install Pillow in wpt virtualenv, r=Sasha

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/5fbd3c3edee2