1987024 - De-comify a bit command handling

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1987024 - De-comify a bit command handling. r=masayuki,smaug,#dom-core

The nsIControllerCommandTable already assumes it's an
nsControllerCommandTable as it has infallible casts. Similarly,
nsIControllerCommand doesn't need to be scriptable.

This is in preparation to expose a global list of always-enabled
commands for the IPC code to use and avoid sending back and forth.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1987024 - Remove nsIControllerContext. r=masayuki,smaug

It only has one implementation, and all the context objects
support weak references.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1987024 - Share command tables across windows / editors / etc. r=masayuki,smaug

It seemed like this was the intention from the code, but it
isn't the case?

I want to use the window command table to always return the
supported commands over IPC (in order to fix bug 1964901).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f4bc770eef1b
https://hg.mozilla.org/integration/autoland/rev/2692aa2b6453
De-comify a bit command handling. r=masayuki,dom-core
https://github.com/mozilla-firefox/firefox/commit/4cc59a7d4205
https://hg.mozilla.org/integration/autoland/rev/74a77dc9bf01
Remove nsIControllerContext. r=masayuki
https://github.com/mozilla-firefox/firefox/commit/a01807ac5894
https://hg.mozilla.org/integration/autoland/rev/80a0d7ecb66d
Share command tables across windows / editors / etc. r=masayuki

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1987024 - Remove unnecessary command name check in nsClipboardCommand. r=masayuki,smaug

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1987024 - Clean up clipboard commands. r=masayuki,smaug

No need to use outparams and co.

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/2692aa2b6453
https://hg.mozilla.org/mozilla-central/rev/74a77dc9bf01
https://hg.mozilla.org/mozilla-central/rev/80a0d7ecb66d

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/718724349a38
https://hg.mozilla.org/integration/autoland/rev/8d9e96a7265c
Remove unnecessary command name check in nsClipboardCommand. r=smaug
https://github.com/mozilla-firefox/firefox/commit/f5e8015c0576
https://hg.mozilla.org/integration/autoland/rev/5ffa9816b539
Clean up clipboard commands. r=jwatt

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/8d9e96a7265c
https://hg.mozilla.org/mozilla-central/rev/5ffa9816b539