1987080 - third_party/llama.cpp/src/llama-mmap.cpp:487:34: error: ?RLIMIT_MEMLOCK? was not declared in this scope; did you mean ?RLIMIT_STACK??

Status: RESOLVED FIXED

(Core :: Machine Learning: General, defect)

Description

[Petr Sumbera]

Steps to reproduce:

Build on Solaris fails with:

35:35.27 /builds/psumbera/mozilla-central-build/third_party/llama.cpp/src/llama-mmap.cpp:487:34: error: ?RLIMIT_MEMLOCK? was not declared in this scope; did you mean ?RLIMIT_STACK??
35:35.27   487 |         if (suggest && getrlimit(RLIMIT_MEMLOCK, &lock_limit)) {
35:35.27       |                                  ^~~~~~~~~~~~~~
35:35.27       |                                  RLIMIT_STACK
35:35.44 At global scope:
35:35.44 cc1plus: note: unrecognized command-line option ?-Wno-tautological-unsigned-enum-zero-compare? may have been intended to silence earlier diagnostics
35:35.49 gmake[4]: *** [/builds/psumbera/mozilla-central-build/config/rules.mk:670: llama-mmap.o] Error 1

The first bad revision is:
changeset: 804706:a6b5919847a1
user: Paul Adenot <[e-mail]>
date: Wed Sep 03 18:46:03 2025 -0700
description:
Bug 1971158 - Vendor llama.cpp. r=glandium

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox Build System::General' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:padenot, since you are the author of the regressor, bug 1971158, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1987080 - Fix llama.cpp build on Solaris. r?atossou

Comment 4

[Paul Adenot (:padenot)]

Petr, I don't have a Solaris machine handy, so I made this work the same as on embedded apple target (watch/tvos) and AIX, it's probably appropriate and will definitely fix the build. I used __sun__ as the #define, as it appeared to be what we generally use (but let me know if it can be better).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9e5d0f159d87
https://hg.mozilla.org/integration/autoland/rev/7cbc32c63a17
Fix llama.cpp build on Solaris. r=atossou

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/7cbc32c63a17

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1971158

Comment 8

[Petr Sumbera]

Thank you for the fix! It builds now again.