1987091 - Migrate some components to use the M3 button color defaults

Status: VERIFIED FIXED

(Firefox for Android :: Logins, task, P2)

Description

[Mira Lobontiu (Android QA)]

Steps to reproduce:

1. Go to Settings - Autofill - Addresses, and add an address.
2. Tap on the saved address, and tap on the delete icon.
3. Go to Settings - Passwords, and save a password.
4. Go to the saved password, and tap on the three-dot menu -> "Delete".
5. Go to Settings - Autofill - Manage cards, and save at least one card.
6. Tap on a saved card, and select the delete icon.

Actual results

The following dialogues displayed after steps 2, 4, and 6 don't match the M3 design:

• the "Delete this address? CANCEL DELETE",
• "Are you sure you want to delete this password? CANCEL DELETE",
• the "Delete card? CANCEL DELETE".

Expected results

The usages of TextButtons have been updated to follow the colours in the new specs found here. There should be no uppercase spec.

Additional details

• Nightly 144.0a1 from 9/4

Comment 1

[Iorga Gabriel]

Attachment: Bug 1987091 - The dialog's buttons should be in lowercase.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/67cd6f3e3d6c
https://hg.mozilla.org/integration/autoland/rev/a73eba47100f
The dialog's buttons should be in lowercase. r=android-reviewers,007

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/a73eba47100f

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Should we uplift this to Beta? Please nominate if so.

Comment 5

[Iorga Gabriel]

Comment on attachment 9518675 [details]
Bug 1987091 - The dialog's buttons should be in lowercase.

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: The dialog's buttons will be in uppercase.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed:
• Is Android affected?: Yes

Comment 6

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/e84be076060f
https://hg.mozilla.org/releases/mozilla-beta/rev/4a59d5393a92

Comment 7

[Adina Petridean QA [:apetridean]]

Verified as fixed on Fenix 145.0b4 using Lenovo Yoga Tab 11 (Android 12) and Google Pixel 7 Pro (Android 14).
The Cancel and Delete buttons now follow the Material 3 default button colors.