Closed Bug 1987111 Opened 1 year ago Closed 1 year ago

Migrate to using the buffer allocator for Scope data

Categories

(Core :: JavaScript Engine, task, P2)

task

Tracking

()

RESOLVED FIXED
144 Branch
Tracking Status
firefox144 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

(Blocks 2 open bugs)

Details

(Keywords: perf-alert)

Attachments

(3 external files)

No description provided.

This removes the AtomT template from NewEmptyScopeData as it is always JSAtom
and removes an include of Scope.h that was responsible for about 1/4 of the
inclusions of this header.

Buffers were previously always owned by a GC thing. However during scope
initialiation we create the data buffer before the scope that will own it. This
patch adds the ability to root un-owned buffers, with the restriction that they
must always be 'tenured owned' buffers.

For rooting we need to also know the zone, so this adds a BufferHolder class
which includes this and adds some template classes to make things more
convenient.

This changes Scope to use the buffer allocator for its external data and
removes its finalizer.

Use of UniquePtr to hold this data is no longer necessary and I converted the
MutableHandles to Handle equialents how we don't need to call release().

Blocks: GC
Severity: -- → N/A
Priority: -- → P2
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 144 Branch
Regressions: 1988128
Regressions: 1989010
QA Whiteboard: [qa-triage-done-c145/b144]

(In reply to Pulsebot from comment #4)

Pushed by jcoppeard@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/659e17952955
https://hg.mozilla.org/integration/autoland/rev/87ca4860a3b2
Part 1: Some minor scope tidyups r=jandem
https://github.com/mozilla-firefox/firefox/commit/2f15664a682d
https://hg.mozilla.org/integration/autoland/rev/6aa037ebfcb6
Part 2: Add support for rooting buffer allocator buffers r=sfink
https://github.com/mozilla-firefox/firefox/commit/999b6ed1f965
https://hg.mozilla.org/integration/autoland/rev/472018a73094
Part 3: Use buffer allocator for scope data r=jandem

Perfherder has detected an awsy performance change from push 472018a73094be90c6eaf7e824575d786cfaf349.

If you have any questions, please reach out to a performance sheriff. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
6% Heap Unclassified windows11-64-24h2-shippable fission tp6 109,021,094.05 -> 102,000,603.28
4% Heap Unclassified macosx1470-64-shippable fission tp6 158,987,887.37 -> 152,102,419.94

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a performance sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 46748

The following documentation link provides more information about this command.

Keywords: perf-alert
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: