1987152 - [Android 14] High Frequency Intermittent Junit Failures

Status: RESOLVED FIXED

(GeckoView :: General, task)

Description

[Olivia Hall [:olivia]]

We have a lot of high frequency intermittent failures in Android 14 v. Android 7.

In this Android 14 try, I (quickly) counted:

domMetadataPlayback - 8
accurateProviderSelected - 7 - some work on this from bug 1979733
dragStartXOriginTest - 5
multipleActions - 3
basicWindowDotPrintTest - 3
switchingProcess - 3
startGeolocationOnBackground - 3
touchEventWithXOrigin - 2
saveAndRestoreStateNewSession - 2
testOnChanged - 2
inputConnection_bug1633621 - 2
backgroundPortDisconnectFromApp - 1
testOpenPopup - 1
disableTest -1
testPopupsCanCloseThemselves - 1
orientationUnlockByExitFullscreen - 1

Not sure if this is some systematic timing change making existing timing issues worse or if we need to individually try to improve each test.

I'll start individually with domMetadataPlayback because it looks like that test could be broken down into smaller tests and I expect improvement by just doing that. However, there might be a global configuration that improves the landscape overall. I'll be on the lookout for that too.

Comment 1

[Olivia Hall [:olivia]]

New try, sent again because the landscape is changing a lot with changes happening in other bugs.

Made some progress on domMetadataPlayback. It seems onMetadata manages to get called an extra time sometimes. So, we need to expect/guard for that.

Comment 2

[Olivia Hall [:olivia]]

Attachment: Bug 1987152 - Adjust domMetadataPlayback Intermittent Failures

domMetadataPlayback occasionally has a 7th onMetadata. This 7th call
has no metadata associated with it. (Likely due to the onStop event.`)
The intermittent failure test will then fail due to this.

Comment 3

[Olivia Hall [:olivia]]

Attachment: Bug 1987152 - Adjust testOnChanged Intermittent Failures in WebExtensionTest

WebExtensionTest#testOnChanged has occasional timeout issues starting in Android 14. Double posting the message that the download updated appears to solve the issue. Wasn't able to identify the reason, but a similar part of the same test also double posts.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7febc70d5a42
https://hg.mozilla.org/integration/autoland/rev/d3736a111148
Adjust domMetadataPlayback Intermittent Failures r=geckoview-reviewers,tcampbell

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/66009ae7a8d0
https://hg.mozilla.org/integration/autoland/rev/af2d0023d77e
Adjust testOnChanged Intermittent Failures in WebExtensionTest r=geckoview-reviewers,tcampbell

Comment 6

[Olivia Hall [:olivia]]

Attachment: Bug 1987152 - Adjust GeolocationTest to improve Intermittent Failures

Logging revealed that the fused location provider was interfering with the test. The test now defines its own fused location provider to prevent disruption.

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/d3736a111148
https://hg.mozilla.org/mozilla-central/rev/af2d0023d77e

Comment 8

[Olivia Hall [:olivia]]

Attachment: Bug 1987152 - Disable Tests with Intermittent Failures on Android 14

This patch is to @Ignore tests that appear to have frequent intermittent failures on Android 14.
Bug for reopening them is bug 1988041.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e008305a79f5
https://hg.mozilla.org/integration/autoland/rev/2584a6034d9a
Adjust GeolocationTest to improve Intermittent Failures r=geckoview-reviewers,calu

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/81c9d78050a6
https://hg.mozilla.org/integration/autoland/rev/464b83095877
Disable Tests with Intermittent Failures on Android 14 r=geckoview-reviewers,tcampbell

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2584a6034d9a

Comment 12

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/464b83095877

Comment 13

[Olivia Hall [:olivia]]

Will need one more round of @Ignores.

Comment 14

[Olivia Hall [:olivia]]

Attachment: Bug 1987152 - Disable More Tests with Intermittent Failures on Android 14

This patch is to @Ignore tests that appear to have frequent intermittent failures on Android 14.
Bug for reopening them is bug 1988041.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6fafd41c30f7
https://hg.mozilla.org/integration/autoland/rev/05d0d8f25f68
Disable More Tests with Intermittent Failures on Android 14 r=geckoview-reviewers,tcampbell

Comment 16

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/05d0d8f25f68