Closed Bug 1987172 Opened 2 months ago Closed 2 months ago

fix tests/address_bar_and_search/test_refresh_firefox_dialog.py

Categories

(Mozilla QA :: STArFox, defect, P1)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: tracy, Assigned: benchatt)

References

(Blocks 1 open bug)

Details

Test Failed in CI and locally. Works manually. In automation send_keys("Refresh Firefox") no longer triggers the expected button.

Bot helped me find that this was broken by landing of https://bugzilla.mozilla.org/show_bug.cgi?id=1958537.
What changed recently (and why your test broke)

The quick action for Refresh Firefox is registered in QuickActionsLoaderDefault.sys.mjs. Its visibility is gated by ResetProfile.resetSupported():

refresh: { … isVisible: () => lazy.ResetProfile.resetSupported(), … }
searchfox.org

On Aug 22, 2025, a change landed titled “Bug 1958537 - Firefox refresh quick action should only be visible for supported profiles.” That means the refresh quick action will now only appear if the profile meets “supported” criteria, which likely excludes many ephemeral/automation (Selenium/WebDriver) profiles.
GitHub

So: manually typing “refresh firefox” in your normal profile still shows the button, but running the same string in a Selenium-created test profile no longer does—because the visibility check now returns false for that profile.

it also suggests following solutions. But I'm not certain what these are doing.

You’ve got a few options:

Make your test profile “supported”
Whatever resetSupported() checks for (e.g., default/non-locked profile, no enterprise policy blocks, profile age/state), mirror those conditions in your Selenium profile so it returns true. The recent policy/eligibility tightening is the likely reason your automation profile fails the check. (The gating change is documented by the Aug 22 commit.)
GitHub

If you must keep the “type in urlbar” behavior
Adjust assertions to:

first probe ResetProfile.resetSupported() in the test and skip (or branch) if false,

or look for the intervention tip variant (from UrlbarProviderInterventions.sys.mjs) if that still appears in your scenario.
searchfox.org

Flags: needinfo?(bchatterton)

I'm going to mark the test unstable due to the recent change in Firefox.

Ben can we take a look at this next week. Not sure the bots suggestions are anything we can implement.

Blocks: 1935159
No longer blocks: 1934609

Let's look at this tmrw, 09/09

Flags: needinfo?(bchatterton)
Assignee: twalker → bchatterton
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.