1987184 - Crash in [@ mozilla::StaticPrefs::media_memory_caches_combined_limit_kb]

Status: RESOLVED WORKSFORME

(Core :: Audio/Video: Playback, defect, P3)

Description

[Andrew McCreight [:mccr8]]

Crash report: https://crash-stats.mozilla.org/report/index/9b756cea-79ce-4dc0-ad37-ee8df0250905

MOZ_CRASH Reason:

MOZ_DIAGNOSTIC_ASSERT(IsAtomic<uint32_t>::value || NS_IsMainThread()) (Non-atomic static pref 'media.memory_caches_combined_limit_kb' being accessed on background thread by getter)

Top 10 frames:

0  libxul.so  MOZ_CrashSequence(void*, long)  mfbt/Assertions.h:253
0  libxul.so  mozilla::StaticPrefs::media_memory_caches_combined_limit_kb()  modules/libpref/init/StaticPrefList_media.h:73
0  libxul.so  mozilla::MemoryBlockCache::EnsureBufferCanContain(unsigned long)  dom/media/MemoryBlockCache.cpp:91
1  libxul.so  mozilla::MemoryBlockCache::WriteBlock(unsigned int, mozilla::Span<unsigned ch...  dom/media/MemoryBlockCache.cpp:156
2  libxul.so  mozilla::MediaCache::AllocateAndWriteBlock(mozilla::MonitorAutoLock&, mozilla...  dom/media/MediaCache.cpp:1746
3  libxul.so  mozilla::MediaCacheStream::FlushPartialBlockInternal(mozilla::MonitorAutoLock&)  dom/media/MediaCache.cpp:2069
4  libxul.so  mozilla::MediaCacheStream::NotifyDataEndedInternal(unsigned int, nsresult)  dom/media/MediaCache.cpp:2118
5  libxul.so  mozilla::MediaCacheStream::NotifyDataEnded(unsigned int, nsresult)::$_0::oper...  dom/media/MediaCache.cpp:2139
5  libxul.so  mozilla::detail::RunnableFunction<mozilla::MediaCacheStream::NotifyDataEnded(...  xpcom/threads/nsThreadUtils.h:549
6  libxul.so  nsThread::ProcessNextEvent(bool, bool*)  xpcom/threads/nsThread.cpp:1151

If this is going to be used on multiple threads, it should be RelaxedAtomicUint32 instead of uint32_t.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jimm, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.