1987270 - Modules exclusively imported with importESModule aren't added to gecko module definitions

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[Mark Striemer [:mstriemer]]

In bug 1976049 we're adding types for Settings UI and UI Widgets. The preferencesBindings.js file is a main entrypoint and unfortunately seems like a decent chunk of work due to legacy reasons to convert to a ESM right now.

As a workaround I figured I'd move its parts into their own ESMs and export those onto window (this is the API that is established) using ChromeUtils.importESModule(). The code works as expected, however there is no type information. I realised that adding the file paths to lib.gecko.modules.d.ts fixes the problem.

Upon investigation it appears that modules imported with importESModule are not actually added to the type definitions, even though it looks like it's intended that they are, it's an issue with the regex grouping.

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1987270 - Include importESModule imports in gecko.module.d.ts r?zombie!,Standard8!,mkennedy

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cee68f7c5863
https://hg.mozilla.org/integration/autoland/rev/85ea7083b208
Include importESModule imports in gecko.module.d.ts r=mkennedy,Standard8

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/85ea7083b208