1987272 - Move the contents of preferencesBindings.js into ESM for better type support in the future

Status: RESOLVED FIXED

(Toolkit :: Preferences, task, P1)

Description

[Mark Striemer [:mstriemer]]

In bug 1976049 we'd like to enable better typescript support for the Settings UI code. This code depends on the preferencesBindings.js file which is somewhat stuck as a regular JS file for now. It has a closure which is preventing types from being exported

We can work around this by extracting its contents into ESMs and exporting them with the same API in preferencesBindings.js

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1987272 - Part 1: Extract preferencesBindings.js classes into ESMs r?mkennedy!,mconley!

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: Bug 1987272 - Part 2: Add Toolkit::Preferences to mots.yaml r?mossop,mconley

Comment 3

[Mark Striemer [:mstriemer]]

Attachment: Bug 1987272 - Part 3: Include about:config in Toolkit::Preferences in mots.yaml r?mossop,mconley

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a6c1c2ab86cc
https://hg.mozilla.org/integration/autoland/rev/f59cbe2e4ee7
Part 1: Extract preferencesBindings.js classes into ESMs r=mkennedy,mconley
https://github.com/mozilla-firefox/firefox/commit/a42125dfdb35
https://hg.mozilla.org/integration/autoland/rev/a8d1e0c87dce
Part 2: Add Toolkit::Preferences to mots.yaml r=mossop,shtrom
https://github.com/mozilla-firefox/firefox/commit/13e2814fdf80
https://hg.mozilla.org/integration/autoland/rev/ae4ce6a2183c
Part 3: Include about:config in Toolkit::Preferences in mots.yaml r=mossop

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f59cbe2e4ee7
https://hg.mozilla.org/mozilla-central/rev/a8d1e0c87dce
https://hg.mozilla.org/mozilla-central/rev/ae4ce6a2183c

Comment 6

[Acasandrei Beatrice (needinfo me)]

(In reply to Pulsebot from comment #4)

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a6c1c2ab86cc
https://hg.mozilla.org/integration/autoland/rev/f59cbe2e4ee7
Part 1: Extract preferencesBindings.js classes into ESMs r=mkennedy,mconley
https://github.com/mozilla-firefox/firefox/commit/a42125dfdb35
https://hg.mozilla.org/integration/autoland/rev/a8d1e0c87dce
Part 2: Add Toolkit::Preferences to mots.yaml r=mossop,shtrom
https://github.com/mozilla-firefox/firefox/commit/13e2814fdf80
https://hg.mozilla.org/integration/autoland/rev/ae4ce6a2183c
Part 3: Include about:config in Toolkit::Preferences in mots.yaml r=mossop

Perfherder has detected a browsertime performance change from push ae4ce6a2183cb2914c2839f6ec98219a09e1fb5f.

If you have any questions, please reach out to a performance sheriff. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
3%	speedometer3 Editor-TipTap/Highlight/Async	macosx1500-aarch64-shippable	fission webrender	1.37 -> 1.34	Before/After

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a performance sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 46907

The following documentation link provides more information about this command.