1987300 - mozregression-gui text is unreadable and not good in Windows 11 dark theme

Status: RESOLVED FIXED

(Testing :: mozregression, defect, P2)

Description

[Alice0775 White]

Attachment: screenshot of sub-dialog

on mozregression-gui 7.0.0rc
STR:

1. Set Windows11 theme to dark color
2. Start mozregression-gui
3. Click on [S] etc

Actual results:
Background color and button hover color are broken and un-readble on hover

Expected results:
The Windows dark theme should be respected.
Or revert to the previous version.

Comment 1

[BugBot [:suhaib / :marco]]

This bug has been marked as a regression. Setting status flag for Nightly to affected.

Comment 2

[Donal Meehan [:dmeehan]]

Not a regression in Firefox, clearing the regression keyword to stop the bot

Comment 3

[Alice0775 White]

Workaround:

1. Right mouse click on the "C:\Program Files (x86)\mozregression-gui\mozregression-gui.exe"
2. Choose "Properties"
3. Compatibility > Compatibility mode > Turn on "Run this program in compatibility mode for"
4. Select "Windows 8" from drop-down menu
5. Click on "OK" button

Comment 7

[Ollie Hensman-Crook [:ollie]]

Attachment: windows_dark_theme_corrected.png

tldr; we can call setWizardStyle(QWizard.WizardStyle.ModernStyle) in the wizard constructor.

I have done some digging after reading this stack overflow post and it seems that the default is to switch from the theme that is set, to Areo for QWizard unless explicitly overridden.

The windows 11 theme inherits from windows vista from what I can tell (based on observation), so this code is executed while initialising the wizard, setting the theme to Aero from whatever the system or configured theme is for windows. Then, Aero seems to explicitly sets the background colour to white.

From the post, setting ModernStyle overrides this behaviour, I think because that unsets the windows vista pending flag but I am not totally sure if that is the exact mechanism.

I have however tested that setting the theme there does fix the issue.

Comment 8

[Ollie Hensman-Crook [:ollie]]

(In reply to Ollie Hensman-Crook [:ollie] from comment #7)

tldr; we can call setWizardStyle(QWizard.WizardStyle.ModernStyle) in the wizard constructor.

It is probably worth guarding this to only be set if the OS is windows.

Comment 9

[BMO Github Automation]

Attachment: [mozilla/mozregression] gui: set theme to ModernStyle to prevent wizard defaulting to Aero on windows (bug 1987300) (#2207)

(via GitHub webhook, authenticated as shared-secret)