Closed
Bug 1987439
Opened 1 year ago
Closed 5 months ago
Replace deprecated color custom properties in in-content/common-shared.css
Categories
(Toolkit :: Themes, task)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
153 Branch
| Tracking | Status | |
|---|---|---|
| firefox153 | --- | fixed |
People
(Reporter: hjones, Assigned: dwhisman)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [recomp][acorntractors])
Attachments
(1 external file)
We have a number of outdated color CSS custom properties in in-content/common-shared.css: https://searchfox.org/firefox-main/rev/1f462a0092bc995d91d3f5f790c197b1bf739954/toolkit/themes/shared/in-content/common-shared.css#38-55
Since we have a full color scale now we should be able to replace the usage of these CSS variables with design tokens. This might not be as straightforward as it sounds - since we have a lint rule that prevents non-semantic usage of our color tokens we will have to find more specific variables to use for the replacements (e.g. we can't just replace --blue-50 with --color-blue-50 but we could replace it with --button-background-color-primary or some other semantic token)
|
||
Updated•1 year ago
|
|
Assignee | |
Updated•6 months ago
|
Assignee: nobody → dwhisman
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•6 months ago
|
||
|
||
Updated•6 months ago
|
Attachment #9574183 -
Attachment description: WIP: Bug 1987439 - Replace deprecated color custom properties in in-content/common-shared.css r=#desktop-theme-reviewers → Bug 1987439 - Replace deprecated color custom properties in in-content/common-shared.css r=#desktop-theme-reviewers
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox153:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
|
||
Updated•4 months ago
|
QA Whiteboard: [qa-triage-done-c154/b153]
You need to log in
before you can comment on or make changes to this bug.
Description
•