1987462 - Crash in `wgpu_hal::dx12::command::impl$4::end_encoding`

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect, P1)

Description

[Robert Conde]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:143.0) Gecko/20100101 Firefox/143.0

Steps to reproduce:

• Go to https://orbit-architect.ai-solutions.com/
• Drag the "Semi-Major Axis" slider

Actual results:

The tab crashes

Expected results:

The visualization updates

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Core::Graphics: WebGPU' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Andy Leiserson [:aleiserson]]

Seems like this may be Windows-specific; I was unable to reproduce on my Mac.

Is there a crash report in about:crashes?

Comment 3

[Robert Conde]

Yes - submitted:
Id before submitting: dccf3500-9bf9-4569-acaa-f4e8eea82cd1
Id after submitting: bp-93762c8d-eaa1-45ee-a783-3ddd50250908

Comment 4

[Andy Leiserson [:aleiserson]]

Thanks. Based on the crash signature it could be https://github.com/gfx-rs/wgpu/issues/5285, but there isn't enough detail in the signature for me to be sure of that.

Comment 5

[BugBot [:suhaib / :marco]]

The bug has a crash signature, thus the bug will be considered confirmed.

Comment 6

[Erich Gubler [:ErichDonGubler] (he/him)]

When I make a debug build of Firefox and use dxcpl.exe to force DX12 debug layers for it, I get these log messages diagnosing the crash:

D3D12 ERROR: ID3D12CommandList::ResourceBarrier: D3D12_RESOURCE_STATES has bits that mismatch support required from D3D12_RESOURCE_FLAGS. [ RESOURCE_MANIPULATION ERROR #524: RESOURCE_BARRIER_MISMATCHING_MISC_FLAGS]
<snip>
[GPU 163656: CanvasRenderer]: E/wgpu_hal::* [wgpu_hal::auxil::dxgi::result] GraphicsCommandList::close failed: The parameter is incorrect. (0x80070057)

…which is a spicy Windows-ey way of suggesting that we're not properly transitioning GPU resources used in render passes. Yikes!

Comment 7

[BugBot [:suhaib / :marco]]

Closing because no crashes reported for 12 weeks.

Comment 8

[Robert Conde]

As of 147.0b1 it still crashes in the same way

Comment 9

[Jim Blandy :jimb]

Thank you for checking and re-opening.

Comment 10

[Andy Leiserson [:aleiserson]]

There is a fix in https://github.com/gfx-rs/wgpu/pull/9346, which will need to be merged to wgpu and then vendored into Firefox.

Comment 11

[Erich Gubler [:ErichDonGubler] (he/him)]

The fix has merged, so now we're Just™ waiting for a revendor.