1987493 - WPTs legend-display.html and fieldset-display.html probably shouldn't mandate support for `display:run-in`

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Daniel Holbert [:dholbert]]

For these two tests, the only subtest that Firefox fails are due to lack of support for display:run-in:

wpt.fyi:
https://wpt.fyi/results/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/fieldset-display.html
https://wpt.fyi/results/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-display.html

wpt.live:
https://wpt.live/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/fieldset-display.html
https://wpt.live/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-display.html

I think these tests are trying to comprehensively test all of the display values that are mentioned in any CSS spec; but given that there are no modern-browser implementations of display:run-in at this point and near-zero non-browser implementations, it probably doesn't make sense to include it as one of the tested values. It may make sense to include this check of test as part of testing the display value (as in https://wpt.fyi/results/css/css-display/parsing/display-computed.html ), and of course for direct tests of run-in itself; but it doesn't really make sense to include it as part of testing fieldset rendering.

Part of the motivation here is that there's a chance we'll propose these tests as part of a fieldset-related interop-202x focus area, so we want to be sure that a 100%-pass-rate is realistically achievable without requiring the implementation of unrelated features.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1987493: Simplify WPTs fieldset-display.html and legend-display.html to not require support for `display:run-in`. r?zcorpan

Comment 2

[Daniel Holbert [:dholbert]]

No huge rush here, but I figured I'd needinfo just in case you don't notice the phab-review-ping. :)

(Hoping to have you review since you're the test author here.)

Comment 3

[Simon Pieters [:zcorpan]]

Thanks for the ping!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4c92c57684d8
https://hg.mozilla.org/integration/autoland/rev/b620647e1661
Simplify WPTs fieldset-display.html and legend-display.html to not require support for `display:run-in`. r=zcorpan

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b620647e1661