1987619 - Investigate & Remove -dontobfuscate in Proguard configuration rules

Status: NEW

(Firefox for Android :: Performance, task)

Description

[Segun Famisa [:segun]]

We currently have -dontobfuscate in our project here:

• https://searchfox.org/firefox-main/rev/1f462a0092bc995d91d3f5f790c197b1bf739954/mobile/android/config/proguard/proguard.cfg#143
• https://searchfox.org/firefox-main/rev/1f462a0092bc995d91d3f5f790c197b1bf739954/mobile/android/fenix/app/proguard-rules.pro#1
• https://searchfox.org/firefox-main/rev/1f462a0092bc995d91d3f5f790c197b1bf739954/mobile/android/focus-android/app/proguard-rules.pro#4

According to Google, having this option in production builds does "significantly limit the extent of optimizations". So we would like to investigate and possibly remove it.

There are potential dependencies to consider:

1. we do not upload our mappings to sentry - see bug 1923139
2. I don't think we do for Socorro either
3. do we upload to Google Play store as well?

As part of this work, we need to investigate our options here. See Google's new guide on keep rules for the effect of -dontobfuscate and how it affects things.

Note to assignee:

1. Feel free to separate the task that does the investigation, from the one that does the implementation.
2. It is advised that this comes in a bit later in the efforts after we have picked up lower hanging fruits.
3. One of the things to look out for is the objects that are passed as arguments in nav_graphs. If R8 starts obfuscating those names, then we will have fatal crashes.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

In regards to where our mappings are uploaded:

• they are not uploaded to Sentry (bug 1923139) or Socorro (bug 1923142)
• but they are automatically uploaded to Google Play.

Comment 2

[Segun Famisa [:segun]]

Thanks so much Petru.

I've also linked the bug for Socorro as something this one depends on.