1987723 - [wpt-sync] Sync PR 54775 - [Masonry] Fix crash in OutOfFlowLayoutPart::GetContainingBlockInfo

Status: RESOLVED FIXED

(Core :: Layout: Grid, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 54775 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/54775
Details from upstream follow.

Yanling Wang <[e-mail]> wrote:

[Masonry] Fix crash in OutOfFlowLayoutPart::GetContainingBlockInfo

This CL addresses a null dereference crash when calling
container_builder_->GetGridLayoutData() in
OutOfFlowLayoutPart::GetContainingBlockInfo. The root cause was that
GridLayoutData was not available when placing out-of-flow children
in the SimplifiedLayoutAlgorithm.
This change ensures that the necessary GridLayoutData is transferred
from the stored layout result, making it available for use in
GetContainingBlockInfo.

Fixed: 443476904
Change-Id: Ideb00e9285414bcdbcf81cdfe4c9b9c5d4ac45e1
Reviewed-on: https://chromium-review.googlesource.com/6926022
WPT-Export-Revision: 6c4c307f235f6f1d8438a77b2da8c2805cb82cda

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e3192a51fd94c99b1153fee26e336ff57459760

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

PASS: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-grid/masonry/tentative/abspos/row-masonry-positioned-item-dynamic-change.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/20a824b5b68e
https://hg.mozilla.org/integration/autoland/rev/a7ab4cc2bcab
[wpt PR 54775] - [Masonry] Fix crash in OutOfFlowLayoutPart::GetContainingBlockInfo, a=testonly
https://github.com/mozilla-firefox/firefox/commit/ed3a75848c1b
https://hg.mozilla.org/integration/autoland/rev/60838afc77bd
[wpt PR 54775] - Update wpt metadata, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a7ab4cc2bcab
https://hg.mozilla.org/mozilla-central/rev/60838afc77bd