1987796 - CardSections assumes that `newtabTrainhop` Nimbus feature has `dailyBriefing` defined

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task)

Description

[Mike Conley (:mconley) (:⚙️) (PTO June 8 - 12)]

STR:

0. Ensure sections is enabled
1. Follow the instructions in https://phabricator.services.mozilla.com/D264079
2. After the last step, go to about:studies and unenroll from the study
3. Open a new tab

Alternatively, instead of enrolling in dailyBriefing as part of Step 1, set the following value for the newtabTrainhop feature:

{
  "type": "test",
  "payload": {
    "enabled": true,
    "sectionId": "top_stories_section",
    "placement": "section"
  }
}

and then open a new tab. This results in a broken set of story cards (if sections is enabled).

Comment 2

[Mike Conley (:mconley) (:⚙️) (PTO June 8 - 12)]

Attachment: Bug 1987796 - Don't assume that dailyBriefing will be defined on trainhopConfig to account for unenrollment / other experiments. r?#home-newtab-reviewers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d84caf9d1165
https://hg.mozilla.org/mozilla-central/rev/89d6d9a06132
Don't assume that dailyBriefing will be defined on trainhopConfig to account for unenrollment / other experiments. r=home-newtab-reviewers,thecount

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/89d6d9a06132