document.cookie not updated by Favicon request
Categories
(Core :: Networking: Cookies, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr140 | --- | unaffected |
| firefox143 | --- | wontfix |
| firefox144 | --- | fixed |
| firefox145 | --- | fixed |
People
(Reporter: jamie, Assigned: baku)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [necko-triaged][necko-priority-queue])
Steps to reproduce:
In Firefox 143,
Steps to reproduce:
- Visit a site that sets XSRF-TOKEN cookie in a favicon request (e.g. Freshdesk Agent portal)
- Attempt to log in
- Login attempt fails with a forbidden message
This issue doesn't happen in the release version of Firefox, but occurs in the beta and developer editions.
This issue can be reproduced on any Freshdesk login form - if you don't have access to one, you're welcome to test against ours with a dummy email/password (broadcastradio.myfreshworks.com) as the XSRF validation occurs very early in the login process.
I'm afraid I haven't had time to run mozregression to determine the exact build when this change occurred - it's quite tricky to run on a Mac
Actual results:
The value of XSRF-TOKEN in document.cookie (e.g. used for a custom header) and the Set-Cookie request differ, causing the login request to fail. The Cookie header in the login request, is the Set-Cookie result from FaviconLoader, but the cookie available in document.cookie / cookieStore is the value from a previous fetch() request
Expected results:
The value of the cookie from FaviconLoader should be written into document.cookie and thus made available to the script on the page
Comment 1•1 year ago
|
||
The Bugbug bot thinks this bug should belong to the 'Core::Networking: Cookies' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
Comment 2•1 year ago
|
||
Thank you for providing the endpoint. So the login returns a 403 and "Forbidden" is shown in the UI when it doesn't work, and a 400 with user and password failure when the correct cookie is present.
I've mozregressed this to bug 1977221.
I assume it's caused by the fact that the favicon loader runs in the parent and doesn't properly deliver the cookie updates, but I haven't dug into the issue.
Updated•1 year ago
|
Comment 3•1 year ago
|
||
:baku, since you are the author of the regressor, bug 1977221, could you take a look?
For more information, please visit BugBot documentation.
Comment 4•1 year ago
|
||
Set release status flags based on info from the regressing bug 1977221
| Assignee | ||
Updated•1 year ago
|
Just as an FYI, as FF143 is now full release, I reported this to FreshDesk and suggested as a work-around to remove Set-Cookie from the favicon request - so the reproduction/example URL may stop working at some point
Comment 6•1 year ago
|
||
Hey :baku, do you have an estimate for when this will land? Are we planning on getting this into 143? If so, we would need an uplift by September 26. Or are we planning on uplifting this into 144? Thanks!
| Assignee | ||
Comment 7•1 year ago
|
||
Yep! The goal is a fix in the next dot-release.
Tested my patch in Bug 1989488 against this bug and it appears to fix. So I believe this is a dupe.
since I can't comment on the other bug, any reason why this isn't being considered for the 143 uplift? it's stopped me and probably a few others being able to use firefox with freshdesk
| Assignee | ||
Comment 10•1 year ago
|
||
We are late for an 143 uplift. It will be in 144.
Updated•1 year ago
|
Description
•