1987926 - Anchor Lookup Should Not Cross Shadow Boundaries

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Shin[:dshin]]

Expected to work as of bug 1924200.

Comment 1

[Jonathan Watt [:jwatt]]

Jari, would you be able to take a look at this?

Comment 2

[David Shin[:dshin]]

I think this is a side effect of missing this little part of the spec:

The anchor name is a tree-scoped name, while anchor spec is a tree-scoped reference.

This means we probably require keeping track of shadow root/document root of the declaration. From my experience with @scope and implicit root, this could get tricky, esp. due to shadow DOM stylesheet sharing - See changes associated with this code.

We could cheat and block referencing anchors across shadow boundaries, but then /css/css-anchor-position/anchor-name-cross-shadow.html would start failing. In fact, that test makes me think that we can't really cheat our way out of tracking the declaration site.

Comment 3

[David Shin[:dshin]]

Ok. I am splitting this ticket is two:

• Disallow anchor references from crossing shadow boundaries altogether (This ticket): We're overly permissive right now. Should change this ASAP.
• Do the actual tree-scope resolution (Bug 1988038).

This affects our path forward for Bug 1986602 as well.

Comment 4

[Jari Jalkanen [:jari]]

I'll look into this.

Comment 5

[Jari Jalkanen [:jari]]

Attachment: Bug 1987926: Anchor lookup should mind cross shadow boundaries. r=#anchor-positioning-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/18e76c60d087
https://hg.mozilla.org/integration/autoland/rev/c25bd14e19d9
Anchor lookup should mind cross shadow boundaries. r=layout-anchor-positioning-reviewers,layout-reviewers,dshin

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c25bd14e19d9