Closed
Bug 1987957
Opened 4 months ago
Closed 4 months ago
Handle removal of last successful position
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
145 Branch
| Tracking | Status | |
|---|---|---|
| firefox145 | --- | fixed |
People
(Reporter: dshin, Assigned: jfkthame)
References
(Blocks 1 open bug)
Details
(Whiteboard: [anchorpositioning:m2])
Attachments
(1 file)
No description provided.
|
Reporter | |
Comment 1•4 months ago
|
||
See spec:
Need to clear last successful position when:
- el is not absolutely positioned
- el’s computed value for position-try-fallbacks has changed
- Any of the @position-try rules referenced by el’s position-try-fallbacks have been added, removed, or mutated.
Last item should be separate, handled by bug 1987960 and bug 1962598
Points: --- → 2
Whiteboard: [anchorpositioning:triage] → [anchorpositioning:m2]
|
Assignee | |
Comment 2•4 months ago
|
||
This should cause the last-fallback to be cleared on any change to the list,
not only if the current index is out-of-range.
(To be on the safe side, for now I've left the existing length check in place
in AbsoluteContainingBlock::ReflowAbsoluteFrame, with an UNREACHABLE assertion,
though we may eventually want to remove it.)
|
||
Updated•4 months ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Pushed by jkew@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/4e216c149b31
https://hg.mozilla.org/integration/autoland/rev/76d615f2488f
Remove any recorded last-successful-fallback if the fallback list changes. r=layout-reviewers,emilio,dshin
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
status-firefox145:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 145 Branch
|
||
Updated•3 months ago
|
QA Whiteboard: [qa-triage-done-c146/b145]
You need to log in
before you can comment on or make changes to this bug.
Description
•