1987963 - Track compensated scroll offsets, i.e. default scroll shift

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Comment 1

[David Shin[:dshin]]

Attachment: Bug 1987963: Compute and cache compensating for scroll state of anchor positioned elements. r=#anchor-positioning-reviewers

Comment 2

[David Shin[:dshin]]

Attachment: Bug 1987963: Apply default scroll offset on scroll. r=#anchor-positioning-reviewers

Comment 3

[David Shin[:dshin]]

Attachment: Bug 1987963: Adjust WPT expectations. r=#anchor-positioning-reviewers

Comment 4

[David Shin[:dshin]]

Attachment: Bug 1987963: Find and reflow affected positioned frames when a frame becomes/stops being a scroll container. r=#anchor-positioning-reviewers

Comment 5

[Timothy Nikkel (:tnikkel)]

Attachment: tallanchor.html

Comment 6

[David Shin[:dshin]]

Attachment: Bug 1987963: Ensure that we can roll back to previous normal position when we give up on finding fallbacks. r=#anchor-pos

Rollback should not happen on "first try" of fallbacks (We have nothing
to fall back to). Modify the last successful fallback to track this.

Comment 7

[David Shin[:dshin]]

Attachment: Testcase where no fallback fits with different fallback ordering

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e83f5939e36a
https://hg.mozilla.org/integration/autoland/rev/48045053f230
Compute and cache compensating for scroll state of anchor positioned elements. r=jwatt
https://github.com/mozilla-firefox/firefox/commit/878edfaa9578
https://hg.mozilla.org/integration/autoland/rev/ce61cc6cef02
Apply default scroll offset on scroll. r=layout-reviewers,tnikkel,jwatt
https://github.com/mozilla-firefox/firefox/commit/9b3130e442de
https://hg.mozilla.org/integration/autoland/rev/fe4d01e5a3d7
Find and reflow affected positioned frames when a frame becomes/stops being a scroll container. r=layout-anchor-positioning-reviewers,firefox-style-system-reviewers,layout-reviewers,emilio
https://github.com/mozilla-firefox/firefox/commit/0685b925e3df
https://hg.mozilla.org/integration/autoland/rev/6dbd1165e668
Ensure that we can roll back to previous normal position when we give up on finding fallbacks. r=layout-anchor-positioning-reviewers,layout-reviewers,emilio
https://github.com/mozilla-firefox/firefox/commit/63d8614128ed
https://hg.mozilla.org/integration/autoland/rev/5f598f8041ca
Adjust WPT expectations. r=layout-anchor-positioning-reviewers,emilio

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/55769 for changes under testing/web-platform/tests

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ed458be3ba7c
https://hg.mozilla.org/integration/autoland/rev/615a7c1aa6f3
Revert (Bug 1987963 Bug 1968745, Bug 1987961) : for causing wr failures @position-visibility-no-overflow-scroll.html.

Comment 11

[agoloman]

Backed out for causing wr failures @position-visibility-no-overflow-scroll.html.

• Backout link
• Push with failures
• Failure Log wr failures
• Failure log wpt failures

Comment 12

[David Shin[:dshin]]

Fixed annotations incoming

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/46693ba1b8b8
https://hg.mozilla.org/integration/autoland/rev/f2d5a1f937bc
Compute and cache compensating for scroll state of anchor positioned elements. r=jwatt
https://github.com/mozilla-firefox/firefox/commit/f61b13a337c1
https://hg.mozilla.org/integration/autoland/rev/cccfa4944f3e
Apply default scroll offset on scroll. r=layout-reviewers,tnikkel,jwatt
https://github.com/mozilla-firefox/firefox/commit/31be694c9976
https://hg.mozilla.org/integration/autoland/rev/a0eab73f08db
Find and reflow affected positioned frames when a frame becomes/stops being a scroll container. r=layout-anchor-positioning-reviewers,firefox-style-system-reviewers,layout-reviewers,emilio
https://github.com/mozilla-firefox/firefox/commit/6a497f0487da
https://hg.mozilla.org/integration/autoland/rev/16d107401f32
Ensure that we can roll back to previous normal position when we give up on finding fallbacks. r=layout-anchor-positioning-reviewers,layout-reviewers,emilio
https://github.com/mozilla-firefox/firefox/commit/30b907bc2066
https://hg.mozilla.org/integration/autoland/rev/0a972d2f0c5a
Adjust WPT expectations. r=layout-anchor-positioning-reviewers,emilio

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/55780 for changes under testing/web-platform/tests

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b135da1f086e
https://hg.mozilla.org/integration/autoland/rev/de3b250218cf
Revert "Bug 1987963, Bug 1968745, Bug 1987961: Adjust WPT expectations. r=layout-anchor-positioning-reviewers,emilio" for causing wpt failures in position-try-fallbacks-003.html.

Comment 17

[Serban Stanca [:SerbanS]]

Reverted this because it was causing wpt failures in position-try-fallbacks-003.html.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-PASS | /css/css-anchor-position/position-try-fallbacks-003.html | redisplay at 100 - expected FAIL

Comment 18

[David Shin[:dshin]]

Missed an unexpected pass, it seems. fix incoming.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5ba984e00abb
https://hg.mozilla.org/integration/autoland/rev/3f69e27f13a2
Compute and cache compensating for scroll state of anchor positioned elements. r=jwatt
https://github.com/mozilla-firefox/firefox/commit/f20c84dcfe39
https://hg.mozilla.org/integration/autoland/rev/1867c86237a2
Apply default scroll offset on scroll. r=layout-reviewers,tnikkel,jwatt
https://github.com/mozilla-firefox/firefox/commit/9453a4960ccd
https://hg.mozilla.org/integration/autoland/rev/bdd7e3a69eb7
Find and reflow affected positioned frames when a frame becomes/stops being a scroll container. r=layout-anchor-positioning-reviewers,firefox-style-system-reviewers,layout-reviewers,emilio
https://github.com/mozilla-firefox/firefox/commit/e6e247e508ee
https://hg.mozilla.org/integration/autoland/rev/d2823c3ebd7e
Ensure that we can roll back to previous normal position when we give up on finding fallbacks. r=layout-anchor-positioning-reviewers,layout-reviewers,emilio
https://github.com/mozilla-firefox/firefox/commit/a4ecd3c15fe6
https://hg.mozilla.org/integration/autoland/rev/85ad73f6fe49
Adjust WPT expectations. r=layout-anchor-positioning-reviewers,emilio

Comment 20

[amarc]

https://hg.mozilla.org/mozilla-central/rev/3f69e27f13a2
https://hg.mozilla.org/mozilla-central/rev/1867c86237a2
https://hg.mozilla.org/mozilla-central/rev/bdd7e3a69eb7
https://hg.mozilla.org/mozilla-central/rev/d2823c3ebd7e
https://hg.mozilla.org/mozilla-central/rev/85ad73f6fe49

Comment 21

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot