1988107 - Show prompt for "DOMRedirectBlockedEvent" on mobile

Status: RESOLVED FIXED

(Firefox for Android :: Browser Engine, enhancement)

Description

[Maurice Dauer [:mdauer]]

In Bug 1419501, we added support for blocking third-party redirects (also known as "framebusting intervention"). When such a redirect is blocked, a DOMRedirectBlockedEvent is triggered, and, currently on desktop only, a notification is shown that allows the user to choose whether to permit the redirect, similar to how popup prompts work.

Since prompts are handled separately on Android, we also need to implement this functionality there.

Comment 1

[Maurice Dauer [:mdauer]]

Attachment: Bug 1988107 - Handle "DOMRedirectBlockedEvent" on mobile, r?freddyb,maltejur

Comment 2

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: For Firefox 144, we implemented a third-party redirect blocker that displays a notification and gives the user the choice to potentially allow a blocked redirect. On Android, these notification are implemented separately and at the moment not shown, thus giving the user no choice. This patch adds that logic for Android.
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Adds new logic to handle a "DOMRedirectBlockedEvent" on Mobile. Unlikely to break anything else. Tests are in place. String changes are made.
• String changes made/needed: yes
• Is Android affected?: yes

Comment 3

[Maurice Dauer [:mdauer]]

Attachment: Bug 1988107 - Handle "DOMRedirectBlockedEvent" on mobile, r?freddyb,maltejur

Original Revision: https://phabricator.services.mozilla.com/D264466

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3ae8bcea05f8
https://hg.mozilla.org/integration/autoland/rev/c17375b3b3fb
Handle "DOMRedirectBlockedEvent" on mobile, r=geckoview-reviewers,android-reviewers,android-l10n-reviewers,geckoview-api-reviewers,delphine,sfamisa,ohall,nalexander

Comment 5

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/c17375b3b3fb

Comment 6

[Donal Meehan [:dmeehan]]

:mdauer, this is a large change to uplift into beta.
Can this ride the train with Fx145?

Comment 7

[Donal Meehan [:dmeehan]]

Discussed on Slack:

• We agreed that there was concern about uplifting this to beta:
  • It has nust landed on main so little bake time
  • It fixes an edge case; the urgency to uplift is low
• Not closing the beta uplift request for now. We can move it to release later, for a possible dot release ride-along.

Comment 8

[Kagami Rosylight [:saschanaz] (they/them)]

BTW the changelog went to v144 when we are in 145 cycle 👀

Comment 9

[Maurice Dauer [:mdauer]]

(In reply to Kagami Rosylight [:saschanaz] (they/them) from comment #8)

BTW the changelog went to v144 when we are in 145 cycle 👀

Ah, I totally forgot about that. I will open a patch to move the changes into the correct cycle.

Comment 10

[Dianna Smith [:diannaS]]

Comment on attachment 9514704 [details]
Bug 1988107 - Handle "DOMRedirectBlockedEvent" on mobile, r?freddyb,maltejur

moving request to release for possible dot release ride-along