1988166 - fatal error: sys/single_threaded.h: No such file or directory

Status: RESOLVED FIXED

(Firefox Build System :: General: Unsupported Platforms, defect, P3)

Description

[Petr Sumbera]

Steps to reproduce:

Solaris build fails with:

 3:04.95 In file included from /usr/gcc/13/include/c++/13.2.0/ext/atomicity.h:38,
 3:04.95                  from /usr/gcc/13/include/c++/13.2.0/bits/ios_base.h:39,
 3:04.96                  from /usr/gcc/13/include/c++/13.2.0/ios:44,
 3:04.96                  from /builds/psumbera/mozilla-central-build/obj-sparc64-sun-solaris2.11/dist/system_wrappers/ios:3,
 3:04.96                  from /builds/psumbera/mozilla-central-build/obj-sparc64-sun-solaris2.11/dist/stl_wrappers/ios:62,
 3:04.96                  from /usr/gcc/13/include/c++/13.2.0/istream:40,
 3:04.96                  from /builds/psumbera/mozilla-central-build/obj-sparc64-sun-solaris2.11/dist/system_wrappers/istream:3,
 3:04.96                  from /builds/psumbera/mozilla-central-build/obj-sparc64-sun-solaris2.11/dist/stl_wrappers/istream:62,
 3:04.96                  from /usr/gcc/13/include/c++/13.2.0/sstream:40,
 3:04.97                  from /builds/psumbera/mozilla-central-build/obj-sparc64-sun-solaris2.11/dist/system_wrappers/sstream:3,
 3:04.97                  from /builds/psumbera/mozilla-central-build/obj-sparc64-sun-solaris2.11/dist/include/mozilla/glue/Debug.h:14,
 3:04.97                  from /builds/psumbera/mozilla-central-build/mozglue/misc/Debug.cpp:7:
 3:04.97 /builds/psumbera/mozilla-central-build/obj-sparc64-sun-solaris2.11/dist/system_wrappers/sys/single_threaded.h:3:15: fatal error: sys/single_threaded.h: No such file or directory
 3:04.97     3 | #include_next <sys/single_threaded.h>
 3:04.97       |               ^~~~~~~~~~~~~~~~~~~~~~~
 3:04.97 /builds/psumbera/mozilla-central-build/nsprpub/pr/src/misc/prnetdb.c: In function ?PR_GetIPNodeByName?:
 3:04.98 compilation terminated.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox Build System::General' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:glandium, since you are the author of the regressor, bug 1987546, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[tt_1]

I guess I just hit this when compiling spidermonkey-144.0_beta1

40:45.63 In file included from /var/tmp/portage/dev-lang/spidermonkey-144.0/work/firefox-144.0/intl/components/src/Bidi.cpp:5:
40:45.64 In file included from /var/tmp/portage/dev-lang/spidermonkey-144.0/work/spidermonkey_build/dist/include/mozilla/intl/Bidi.h:8:
40:45.64 In file included from /var/tmp/portage/dev-lang/spidermonkey-144.0/work/spidermonkey_build/dist/include/mozilla/intl/ICU4CGlue.h:8:
40:45.65 In file included from /var/tmp/portage/dev-lang/spidermonkey-144.0/work/spidermonkey_build/dist/system_wrappers/unicode/uenum.h:3:
40:45.66 In file included from /usr/include/unicode/uenum.h:25:
40:45.66 In file included from /usr/include/unicode/localpointer.h:45:
40:45.67 In file included from /var/tmp/portage/dev-lang/spidermonkey-144.0/work/spidermonkey_build/dist/system_wrappers/memory:3:
40:45.68 In file included from /usr/lib/gcc/armv7a-unknown-linux-musleabihf/14/include/g++-v14/memory:80:
40:45.68 In file included from /usr/lib/gcc/armv7a-unknown-linux-musleabihf/14/include/g++-v14/bits/shared_ptr.h:53:
40:45.69 In file included from /usr/lib/gcc/armv7a-unknown-linux-musleabihf/14/include/g++-v14/bits/shared_ptr_base.h:61:
40:45.70 In file included from /usr/lib/gcc/armv7a-unknown-linux-musleabihf/14/include/g++-v14/ext/atomicity.h:38:
40:45.71 /var/tmp/portage/dev-lang/spidermonkey-144.0/work/spidermonkey_build/dist/system_wrappers/sys/single_threaded.h:3:15: fatal error: 'sys/single_threaded.h' file not found
40:45.71 3 | #include_next <sys/single_threaded.h>
40:45.72 | ^~~~~~~~~~~~~~~~~~~~~~~
40:50.57 1 error generated.

Comment 4

[tt_1]

Attachment: build.log.gz

full build log, using clang-20

Comment 5

[Petr Sumbera]

For Solaris I use following workaround (not good for Linux):

diff -r a69500eb2373 -r 535aa421e6ef config/system-headers.mozbuild                                                  
--- a/config/system-headers.mozbuild    Thu Oct 05 00:56:26 2023 -0700
+++ b/config/system-headers.mozbuild    Thu Sep 11 23:11:19 2025 -0700                                               
@@ -864,7 +864,6 @@          
     "sys/shm.h",                                                                                                    
     "sys/siginfo.h",        
     "sys/signal.h",                                                                                                 
-    "sys/single_threaded.h",
     "sys/socket.h",                                                                                                 
     "sys/sockio.h",         
     "sys/sparc/frame.h",                                                                                            
@@ -1376,6 +1375,7 @@        
 if CONFIG["OS_TARGET"] in ("Android", "Linux", "FreeBSD"):
     system_headers += [
         "sys/auxv.h",
+        "sys/single_threaded.h",
     ]
 
 if CONFIG["OS_TARGET"] == "Linux" and CONFIG["TARGET_CPU"].startswith("mips"):

Comment 6

[Patrycja Rosa [:ptrcnull] (she/her)]

I can reproduce as well - sys/single_threaded.h does not exist on Musl, and simply removing it from system_headers seems to make the build go through.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit BugBot documentation.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

don't hesitate to provide a patch :)

Comment 9

[conor]

Attachment: Bug 1988166 - Only wrap sys/single_threaded.h when it actually exists. r=glandium

sys/single_threaded.h is glibc/FreeBSD-specific and does not
exist on musl libc, breaking the build.

Follow the same approach as bug 1952657 (execinfo.h): move the
header out of the unconditional system_headers list and gate it
on a check_header() probe.

Comment 10

[tt_1]

thanks for the patch, I've just tested it with spidermonkey-153.0_beta2, on a musl system, and it works perfectly fine.

if it sticks to nightly, please consider a backport for 152.0-esr branch, and 153.0_beta branch.

Comment 11

[tt_1]

hey, the fix is working as intended.

can the process of merging this into nightly be triggered, please?

Comment 12

[Alex Hochheiden [:ahochheiden] [he/him]]

I've queued it to land.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a5cb1ae19389
https://hg.mozilla.org/integration/autoland/rev/d4cc2c896615
Only wrap sys/single_threaded.h when it actually exists. r=glandium

Comment 14

[tt_1]

[Tracking Requested - why for this release]:

this bug also affects firefox-153.0 beta branch, which will become firefox-153.0-esr branch soon.

please uplift to 153.0 beta branch if there is still time to do it, if not please uplift to firefox-153.0-esr branch

thank you

Comment 15

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d4cc2c896615

Comment 16

[conor]

Hi @tt_1, would uplifting to 153.0 be something I have to do? Apologies as this is my first contribution and amn't too sure how it works haha, will be happy to help if you could let me know what I have to do!(In reply to tt_1 from comment #14)

[Tracking Requested - why for this release]:

this bug also affects firefox-153.0 beta branch, which will become firefox-153.0-esr branch soon.

please uplift to 153.0 beta branch if there is still time to do it, if not please uplift to firefox-153.0-esr branch

thank you

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:conorboyle07, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox153 to wontfix.

For more information, please visit BugBot documentation.

Comment 18

[Mike Hommey [:glandium]]

Attachment: Bug 1988166 - Only wrap sys/single_threaded.h when it actually exists.

sys/single_threaded.h is glibc/FreeBSD-specific and does not
exist on musl libc, breaking the build.

Follow the same approach as bug 1952657 (execinfo.h): move the
header out of the unconditional system_headers list and gate it
on a check_header() probe.

Original Revision: https://phabricator.services.mozilla.com/D308106

Comment 19

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Tier 3 build failure
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Very limited build-only change
• String changes made/needed?: N/A
• Is Android affected?: no

Comment 20

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/0c7262c4b049
https://hg.mozilla.org/releases/mozilla-beta/rev/a476033d2b71