Closed Bug 1988251 Opened 1 year ago Closed 11 months ago

display a link to Lando on successful `moz-phab uplift`

Categories

(Conduit :: moz-phab, enhancement, P3)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sheehan, Assigned: sheehan)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

When moz-phab uplift is successful, we should display the URL for the Lando revision to fill out the uplift request assessment form.

I also have a patch in progress to auto-open Lando in the browser. It's slightly more complicated as we need a config option to disable opening the browser, interplay with --yes and other config options, etc. I'll send that as a follow-up as having the URL available is valuable on it's own.

After bug 1987196, the uplift request assessment in Phabricator
has been removed and Lando must be used to respond to the form.
Display a link to the Lando URL for the revision on successful
moz-phab uplift.

Update the submit command handler to return the list of commits
it generated, and use the tip commit in the stack to build the
Lando URL. Add a mapping of known Phabricator domains to their
associated Lando domains and provide a helper method on the
repository object to get the Lando URL.

Authored by https://github.com/cgsheeh
https://github.com/mozilla-conduit/review/commit/8701aa51310c51e7e6f731435d0c27a3f4f7325d
[main] uplift: display Lando URL for the new revision on successful moz-phab uplift (Bug 1988251) r=shtrom

Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Depends on: 1982619
Blocks: 1987179
Regressions: 1994123
Duplicate of this bug: 1987179
No longer blocks: 1987179
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: