1988297 - Crash in [@ java.lang.IllegalStateException: at mozilla.components.lib.push.firebase.AbstractFirebasePushService.onMessageReceived(AbstractFirebasePushService.kt:85)]

Status: RESOLVED FIXED

(Firefox for Android :: Push, defect)

Description

[Andrew McCreight [:mccr8]]

Crash report: https://crash-stats.mozilla.org/report/index/758ae746-cd83-4e79-949b-16c4b0250911

Top 7 frames:

0  mozilla.components.lib.push.firebase.AbstractFirebasePushService  onMessageReceived  AbstractFirebasePushService.kt:85
1  com.google.firebase.messaging.FirebaseMessagingService  handleIntent  FirebaseMessagingService.java:291
2  com.google.firebase.messaging.EnhancedIntentService$$ExternalSyntheticLambda1  run  R8$$SyntheticClass:10
3  java.util.concurrent.ThreadPoolExecutor  runWorker  ThreadPoolExecutor.java:1167
4  java.util.concurrent.ThreadPoolExecutor$Worker  run  ThreadPoolExecutor.java:641
5  com.google.android.gms.common.util.concurrent.zza  run  com.google.android.gms:play-services-basement@@18.7.1:7
6  java.lang.Thread  run  Thread.java:919

Comment 1

[Andrew McCreight [:mccr8]]

Big spike in this, though not all on 144. Also, lots of crashes but only around 48 installations. Which still feels like a lot for Android Nightly.

Comment 2

[Donal Meehan [:dmeehan]]

This is likely fallout from Bug 1985845

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 10 AArch64 and ARM crashes on nightly

For more information, please visit BugBot documentation.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

This is still showing up in pretty high volume from newer Nightly builds. I think we need to bump the priority & severity here.

java.lang.IllegalStateException: You need to call PushProcessor.install() on your Push instance from Application.onCreate().
	at mozilla.components.lib.push.firebase.AbstractFirebasePushService.onMessageReceived(AbstractFirebasePushService.kt:85)
	at com.google.firebase.messaging.FirebaseMessagingService.handleIntent(FirebaseMessagingService.java:291)
	at com.google.firebase.messaging.EnhancedIntentService$$ExternalSyntheticLambda1.run(R8$$SyntheticClass:10)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1156)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:651)
	at com.google.android.gms.common.util.concurrent.zza.run(com.google.android.gms:play-services-basement@@18.9.0:7)
	at java.lang.Thread.run(Thread.java:1119)

Comment 5

[Ryan VanderMeulen [:RyanVM]]

This is currently the top overall Fenix Nightly crash.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Copying crash signatures from duplicate bugs.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox145 (nightly). We have limited time to fix this, the soft freeze is in 3 days. However, the bug still isn't assigned.

:boek, could you please find an assignee for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Volume is down substantially since bug 1989865 landed, but not completely gone.

Comment 10

[Segun Famisa [:segun]]

This crash also seems related to the partial initialization that happens in "recovery mode" after a startup crash. We do not set up the push service, so if a user receives a push in that mode, this crash happens. It's similar to what I have seen while investigating bug 1988212

In fact, I believe it is the same crash - if you click on the sentry link in https://bugzilla.mozilla.org/show_bug.cgi?id=1988212#c0, you'll see that the stack traces are identical.

I also understand that there is an effort to fix some of the issues that resulted from partial initialization in bug 1992494, so I'll make this bug depend on it (unless anyone disagrees), with the hopes that once bug 1992494 is resolved, this bug too will be resolved.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

Based on the topcrash criteria, the crash signatures linked to this bug are not in the topcrash signatures anymore.

For more information, please visit BugBot documentation.

Comment 12

[Jeff Boek [:boek]]

This should be fixed with bug 1992494