Closed Bug 1988475 Opened 1 year ago Closed 1 year ago

Assertion failure: CurrentThreadIsGCMarking() || CurrentThreadCanAccessZone(zone), at gc/Cell.h:463

Categories

(Core :: JavaScript Engine, defect, P1)

x86_64
Linux
defect

Tracking

()

VERIFIED FIXED
145 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr140 --- unaffected
firefox143 --- unaffected
firefox144 --- disabled
firefox145 --- verified

People

(Reporter: decoder, Assigned: jonco)

References

(Regression)

Details

(5 keywords, Whiteboard: [bugmon:update,bisected,confirmed])

Attachments

(2 files, 1 external file)

The following testcase crashes on mozilla-central revision 20250913-1172f45a3c14 (debug build, run with --fuzzing-safe --ion-offthread-compile=off --enable-symbols-as-weakmap-keys):

evalInWorker(`
  class a {}
  b = new WeakRef(Symbol.hasInstance)
  a(b.deref())
`)

Backtrace:

received signal SIGSEGV, Segmentation fault.
#0  0x0000555556eee008 in js::gc::TenuredCell::zone() const ()
#1  0x00005555575ebdc5 in js::WeakRefObject::deref(JSContext*, unsigned int, JS::Value*) ()
#2  0x000055555704eeb5 in CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), js::CallReason, JS::CallArgs const&) ()
#3  0x000055555704e5c0 in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) ()
#4  0x0000555557062439 in js::Interpret(JSContext*, js::RunState&) ()
#5  0x000055555704db34 in js::RunScript(JSContext*, js::RunState&) ()
#6  0x0000555557051141 in js::ExecuteKernel(JSContext*, JS::Handle<JSScript*>, JS::Handle<JSObject*>, js::AbstractFramePtr, JS::MutableHandle<JS::Value>) ()
#7  0x000055555705172f in js::Execute(JSContext*, JS::Handle<JSScript*>, JS::Handle<JSObject*>, JS::MutableHandle<JS::Value>) ()
#8  0x00005555571a1452 in ExecuteScript(JSContext*, JS::Handle<JSObject*>, JS::Handle<JSScript*>, JS::MutableHandle<JS::Value>) ()
#9  0x00005555571a1260 in JS_ExecuteScript(JSContext*, JS::Handle<JSScript*>, JS::MutableHandle<JS::Value>) ()
#10 0x0000555556f1ed1a in WorkerMain(std::unique_ptr<WorkerInput, JS::DeletePolicy<WorkerInput> >) ()
#11 0x0000555556f1f28a in js::detail::ThreadTrampoline<void (&)(std::unique_ptr<WorkerInput, JS::DeletePolicy<WorkerInput> >), std::unique_ptr<WorkerInput, JS::DeletePolicy<WorkerInput> > >::Start(void*) ()
#12 0x0000555556f7a84d in set_alt_signal_stack_and_start(PthreadCreateParams*) ()
#13 0x00007ffff769caa4 in ?? () from /lib/x86_64-linux-gnu/libc.so.6
#14 0x00007ffff7729c3c in ?? () from /lib/x86_64-linux-gnu/libc.so.6
rax	0x0	0
rbx	0x7ffff4248000	140737289420800
rcx	0x1cf	463
rdx	0x7ffff7804563	140737345766755
rsi	0x0	0
rdi	0x7ffff7805700	140737345771264
rbp	0x7ffff4bfe200	140737299603968
rsp	0x7ffff4bfe1f0	140737299603952
r8	0x0	0
r9	0x3	3
r10	0x0	0
r11	0x293	659
r12	0x7ffff4bfe240	140737299604032
r13	0x19bbde328d60	28294677433696
r14	0x7ffff4bfe220	140737299604000
r15	0x7ffff4bfe230	140737299604016
rip	0x555556eee008 <js::gc::TenuredCell::zone() const+280>
=> 0x555556eee008 <_ZNK2js2gc11TenuredCell4zoneEv+280>:	mov    %rcx,(%rax)
   0x555556eee00b <_ZNK2js2gc11TenuredCell4zoneEv+283>:	call   0x555556f67580 <abort>

Not sure if this is covered by one of the existing bugs on file already, so filing just in case this is something else (involves deref()).

Attached file Testcase —

Verified bug as reproducible on mozilla-central 20250915163235-cffc6790b708.
The bug appears to have been introduced in the following build range:

Start: 9786291f3312a108c81c8ef5ce0bde18fdc4e6af (20250905010130)
End: 9e06db4da20903f3daed4e3295ad8ac2f990984d (20250904082226)
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9786291f3312a108c81c8ef5ce0bde18fdc4e6af&tochange=9e06db4da20903f3daed4e3295ad8ac2f990984d

Whiteboard: [bugmon:update,bisect] → [bugmon:update,bisected,confirmed]
Regressed by: 1863140

:jonco, since you are the author of the regressor, bug 1863140, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Flags: needinfo?(jcoppeard)
Attached file (secure) —

Similar to the fix for bug 1987516. We don't need to add permanent things to
this set, and it's a race if we try and do so for shard atoms.

Assignee: nobody → jcoppeard
Status: NEW → ASSIGNED

This affects nightly only.

Flags: needinfo?(jcoppeard)
See Also: → 1987516
Severity: -- → S3
Priority: -- → P1
Group: javascript-core-security → core-security-release
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 145 Branch

Verified bug as fixed on rev mozilla-central 20250917161633-eb4cc6a1344e.
Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.

Status: RESOLVED → VERIFIED
Keywords: bugmon
Group: core-security-release
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: