1988477 - Firefox Android: keyboard incognito mode is not activated in Private tabs (tested with Swiftkey)

Status: VERIFIED FIXED

(Firefox for Android :: Privacy, defect)

Description

[klint]

User Agent: Mozilla/5.0 (Android 12; Mobile; rv:144.0) Gecko/144.0 Firefox/144.0

Steps to reproduce:

I switched to private browsing

Actual results:

The keyboard did not enter in incognito mode automatically as it used to do.

Expected results:

Incognito mode should have been activated in Private browsing.
Using SwiftKey here.

Comment 1

[Timothy Pelayo]

Confirming that this problem is not keyboard specific as I am also experiencing this with Gboard v15.9.1.799068799-beta-arm64-v8a.

Comment 2

[klint]

And to be more specific, this is only Irh new compose toolbar activated

Comment 3

[Donal Meehan [:dmeehan]]

Fx144 is now in beta.
:Gela, could this be triaged? I'm not sure what the regressor is here, you might know?
There were some recent changes in Private Browsing related to Bug 1971378.

Comment 4

[:Gela]

:dmeehan I don't know what could have caused this, but I'd be very surprised if it's related to the PBM changes squad 2 has worked on. Since this is only happening with the new compose toolbar, I suspect this may be related to something Squad 3 (KitKat) has worked on. I've reached out to Petru to confirm

Comment 5

[Petru-Mugurel Lingurar [:petru]]

If it only happens with the new toolbar we can take it.
To note that the new toolbar is not enabled by default in 144 but through a staged rollout.

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1988477 - Use incognito mode for keyboard when searching in private mode r=#android-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1ddd659e77bd
https://hg.mozilla.org/integration/autoland/rev/8dec83188fcd
Use incognito mode for keyboard when searching in private mode r=android-reviewers,Roger

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8dec83188fcd

Comment 9

[Donal Meehan [:dmeehan]]

:petru, Fx144 is set to disabled based on Comment 5.
Though I wonder if there's still a need to uplift this to beta? The behavior appears poor for participants enrolled in the experiment.

Comment 10

[Petru-Mugurel Lingurar [:petru]]

Thanks! Agree.
Will request uplift after QA validates everything works as expected.

Comment 11

[Mira Lobontiu (Android QA)]

Attachment: 1988477.jpg

Comment 12

[Mira Lobontiu (Android QA)]

Verified as fixed on the latest Firefox for Android Nightly 145.0a1 from 9/24 using a Samsung Galaxy S24 (Android 15), and a Pixel 6 (Android 16).
Microsoft Swiftkey, and Gbaord both display the incognito mode, but Samsung keyboard doesn't.
Petru, please take a look.

Comment 13

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: When searching in private tabs the keyboard is not in incognito mode and could record user's input.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Check that the keyboard is in incognito mode when searching in private tabs and not in this mode when searching in normal tabs.
• Risk associated with taking this patch: low
• Explanation of risk level: Small change verified by QA.
• String changes made/needed: --
• Is Android affected?: yes

Comment 14

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1988477 - Use incognito mode for keyboard when searching in private mode r=#android-reviewers

Original Revision: https://phabricator.services.mozilla.com/D265218

Comment 15

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/4c40ee463396
https://hg.mozilla.org/releases/mozilla-beta/rev/79f90657c7e3

Comment 16

[Adina Petridean QA [:apetridean]]

Verified as fixed on the latest Firefox 144.0b6 using Samsung Galaxy S23 Ultra (Android 14) and Xperia 10 XQ-BT5210 (Android 12).
Microsoft Swiftkey, and Gbaord both display the incognito mode!